[svk-devel] [PATCH] Verbose commits (includes ? files in commitlog)

[Jesse Vincent]

On Thu, Jun 07, 2007 at 09:27:22PM +0200, Dominique Quatravaux wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Wincent Colaiuta wrote:
> >
> >> But, the 'A'dd operation *will* recurse, and then thousands of
> >> kittens will die! :0
> >
> > Yes, but that's consistent with the behaviour of "svk add".
> 
> Maybe so. However, when changing a ? to an A in the editor on a
> directory, the recursive behavior will happen at *commit time*, ie in
> an irreversible fashion. This could mean appending megabytes or even
> gigabytes of data to ~/.svk, and we all know how painful it is to get
> rid of unwanted revisions in the underlying Subversion repository.
> 
> I therefore think it is a bad idea, and that consistency should yield
> to the principle of least astonishment.

POLS would say to me that it works like adding the directory from the
commandline, not that it would only add the toplevel directory.

But I could see an argument for just having the message recursively show
all files in ? directories.

-j