[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-164-g31e78c8

Thomas Sibley trs at bestpractical.com
Fri Jul 22 17:55:22 EDT 2011


The branch, 3.8/perlcritic has been updated
       via  31e78c8366ca39dc4b0b22ad36341553112546cb (commit)
      from  3a356e291aaa3054522503cb68b82aac3eff5169 (commit)

Summary of changes:
 lib/RT/Tickets_Overlay.pm    |    1 -
 sbin/factory                 |    2 +-
 sbin/rt-test-dependencies.in |    1 -
 3 files changed, 1 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 31e78c8366ca39dc4b0b22ad36341553112546cb
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jul 22 17:54:35 2011 -0400

    Remove some more declared but not used variables

diff --git a/lib/RT/Tickets_Overlay.pm b/lib/RT/Tickets_Overlay.pm
index 650f1af..b9634cc 100755
--- a/lib/RT/Tickets_Overlay.pm
+++ b/lib/RT/Tickets_Overlay.pm
@@ -760,7 +760,6 @@ sub _TransLimit {
         );
     }
 
-    my $ret;
     #Search for the right field
     if ( $field eq 'Content' and RT->Config->Get('DontSearchFileAttachments') ) {
         $self->_OpenParen;
diff --git a/sbin/factory b/sbin/factory
index afa52a1..3d71807 100755
--- a/sbin/factory
+++ b/sbin/factory
@@ -131,7 +131,7 @@ my $dbh = DBI->connect( $dsn, $user, $password );
 #get all tables out of database
 my @tables = map { m/^\`\Q$database\E\`\.(.*)/ ? $1 : $_ } $dbh->tables();
 
-my ( %tablemap, $typemap, %modulemap );
+my ( %tablemap, %modulemap );
 
 foreach my $table (@tables) {
     $table =~ s/\`//g;
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 723ed7c..3892733 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -403,7 +403,6 @@ foreach my $type (sort grep $args{$_}, keys %args) {
     $type = $1;
     section("$type dependencies");
 
-    my @missing;
     my @deps = @{ $deps{$type} };
 
     my %missing = test_deps(@deps);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list