[Rt-commit] rt branch, 4.6/fontawesome-icons, repushed

Blaine Motsinger blaine at bestpractical.com
Tue Nov 5 10:39:15 EST 2019


The branch 4.6/fontawesome-icons was deleted and repushed:
       was df5400f1b370060082c6e7c967dbdf38083cee19
       now d453a754712218bda6c3928fe55b6f3bd8565e21

1: 4f90e82c96 = 1: 4f90e82c96 Add project-diagram to fontawesome SVG build
2: e571ceb5b2 = 2: e571ceb5b2 Replace text links with fontawesome SVGs
3: 257d577303 = 3: 257d577303 Remove timer and bookmark css and images
4: c60962d032 = 4: c60962d032 Add alt and title tooltips for new icons
5: 4033683ef3 ! 5: 4aaf382339 Enable bootstrap tooltips
    @@ -11,8 +11,8 @@
         associated with any svg.
         
         To ensure the tooltips are cycled correctly, we run the tooltip
    -    dispose method for any tooltip divs before replacing the bookmark
    -    links.
    +    hide then dispose methods for any tooltip divs before replacing
    +    the bookmark links.
     
     diff --git a/share/html/Ticket/Elements/Bookmark b/share/html/Ticket/Elements/Bookmark
     --- a/share/html/Ticket/Elements/Bookmark
    @@ -37,15 +37,20 @@
     +
     +// enable bootstrap tooltips
     +jQuery(function() {
    -+    jQuery("body").tooltip({ selector: '[data-toggle=tooltip]' });
    ++    jQuery("body").tooltip({
    ++        selector: '[data-toggle=tooltip]',
    ++        trigger: 'hover focus'
    ++    });
     +});
     +
     +// toggle bookmark for Ticket/Elements/Bookmark.
    -+// before replacing the bookmark content, dispose of the existing tooltip to
    ++// before replacing the bookmark content, hide then dispose of the existing tooltip to
     +// ensure the tooltips are cycled correctly.
     +function toggle_bookmark(url, id) {
     +    jQuery.get(url, function(data) {
    -+        jQuery('div[id^="tooltip"]').tooltip('dispose');
    ++        var bs_tooltip = jQuery('div[id^="tooltip"]');
    ++        bs_tooltip.tooltip('hide');
    ++        bs_tooltip.tooltip('dispose');
     +        jQuery('.toggle-bookmark-' + id).replaceWith(data);
     +    });
     +}
6: f63758b940 = 6: f7ecbce565 Add border styling for icons
7: 911f9570fb = 7: 112cd737d9 Update test for removing bookmark imgs
8: df5400f1b3 = 8: d453a75471 Fix test to find link via regex instead of text



More information about the rt-commit mailing list