[rt-devel] RT 1.3.59 - Eve-before-beta

[Jesse]

Here's a patch to fix it within the Action API.

===================================================================
RCS file: /raid/cvsroot/rt/lib/RT/Action/Attic/NotifyAsComment.pm,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 NotifyAsComment.pm
--- NotifyAsComment.pm  2000/12/06 04:24:32     1.1.2.1
+++ NotifyAsComment.pm  2001/03/21 17:19:56
@@ -1,6 +1,24 @@
+#$Header$
+
 package RT::Action::NotifyAsComment;
 require RT::Action::Notify;
 @ISA = qw(RT::Action::Notify);
 
+
+=head2 Prepare
+
+Tell SendEmail that this message should come out as a comment. Then call SUPER::Prepare
+
+=cut
+
+sub Prepare {
+       my $self = shift;
+       
+       #TODO: this should be cleaner.
+       #Tell RT::Action::SendEmail that this should come from the relevant comment email address.
+       $self->{'comment'} = 1;
+       
+       return($self->SUPER::Prepare(@_));      
+}
 1;


On Wed, Mar 21, 2001 at 12:14:02PM -0500, Jesse wrote:
> 
> On Wed, Mar 21, 2001 at 09:06:39AM -0800, ivan wrote:
> > On Wed, Mar 21, 2001 at 04:19:38PM +0000, Kevin Croombs wrote:
> > 
> > > I have a scrip configured - "OnComment NotifyAdminWatchersAsComment
> > > with template AdminComment".  This appears to work - admin watchers
> > > are notified, but the email has "From:" set to the correspondence
> > > address rather than the comment address.  Is this a bug?
> > 
> > Yes, I was recently bitten by this.  Here's a fix:
> 
> Thanks
> 
> > > I would expect the "AsComment" actions to have from set to the comment
> > > address.
> > 
> > As did I...
> 
> As did I.
> 
> > -- 
> > meow
> > _ivan
> > 
> > _______________________________________________
> > Rt-devel mailing list
> > Rt-devel at lists.fsck.com
> > http://lists.fsck.com/mailman/listinfo/rt-devel
> > 
> 
> -- 
> jesse reed vincent -- root at eruditorum.org -- jesse at fsck.com 
> 70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90
> 
> They'll take my private key when they pry it from my cold dead fingers!
> 
> _______________________________________________
> Rt-devel mailing list
> Rt-devel at lists.fsck.com
> http://lists.fsck.com/mailman/listinfo/rt-devel
> 

-- 
jesse reed vincent -- root at eruditorum.org -- jesse at fsck.com 
70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90

There are no supercomputer applications that are solvable that cannot be solved
in finite time using a fucking TRS-80 with approprite disk/tape drives.  Zero.
									-Tanj