[Bps-public-commit] rt-authen-externalauth branch, master, updated. 0.25

[Kevin Falcone]

The branch, master has been updated
       via  412794ed93cd4e087e1661b1401663c663ceebb4 (commit)
       via  abc898af13555829c505f78e65bad19986028ad1 (commit)
       via  36768caa13cca9d7e022d5f45d07a58b59cbe900 (commit)
      from  9ab3c84c66d9d01653b8090ee4339aff996b82af (commit)

Summary of changes:
 CHANGES                       | 3 +++
 META.yml                      | 2 +-
 html/Elements/DoAuth          | 7 ++++++-
 lib/RT/Authen/ExternalAuth.pm | 2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 36768caa13cca9d7e022d5f45d07a58b59cbe900
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Thu Oct 16 16:39:14 2014 -0400

    Avoid sending blank lines at the top of responses
    
    Because of a trailing newline in this file, when RT served images from
    the non-static-handler, it would inject a blank line at the top of the
    file, breaking it.  This caused custom logos and charts from search
    results to fail to render.
    
    This was caused when eeb05b8f lost the return; at the end of init,
    allowing the blank line to be printed.
    
    This restores the return, with a helpful comment for the future and also
    futureproofs by removing the blank lines.

diff --git a/html/Elements/DoAuth b/html/Elements/DoAuth
index e3a707b..3c10bc8 100644
--- a/html/Elements/DoAuth
+++ b/html/Elements/DoAuth
@@ -14,9 +14,11 @@ if ( $val ) {
 RT::Interface::Web::Redirect( $next )
     if $val and $next
    and $m->request_comp->path eq '/NoAuth/Login.html';
+
+# this component should never generate content
+return;
 </%init>
 <%ARGS>
 $user => undef
 $pass => undef
 </%ARGS>
-

commit abc898af13555829c505f78e65bad19986028ad1
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Thu Oct 16 16:44:48 2014 -0400

    Quiet logging for logged in users
    
    Because we started deferring to ::DoAuth in eeb05b8f, we would log a
    message of:
        Autohandler called ExternalAuth. Response: (0, User already logged in!)
    for every request once it checked that the user was logged in.
    Instead, just bail hard once we see that the user is logged in.

diff --git a/html/Elements/DoAuth b/html/Elements/DoAuth
index 3c10bc8..09b9bd7 100644
--- a/html/Elements/DoAuth
+++ b/html/Elements/DoAuth
@@ -1,4 +1,7 @@
 <%init>
+# return as quickly as possible if the user is logged in
+return if $session{CurrentUser} && $session{'CurrentUser'}->id;
+
 # It's important to nab the next page from the session before we
 # potentially blow the session away below.
 my $next = $session{'NextPage'}->{ $ARGS{'next'} || "" };

commit 412794ed93cd4e087e1661b1401663c663ceebb4
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Thu Oct 16 16:52:19 2014 -0400

    Bump version for 0.25

diff --git a/CHANGES b/CHANGES
index e1a62db..762d13f 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+0.25 2014-10-16
+ - Fix a regression causing Charts and Custom Logos to not render properly
+
 0.24 2014-10-09
  - No changes since 0.23_01
 
diff --git a/META.yml b/META.yml
index 76fe904..40e1dee 100644
--- a/META.yml
+++ b/META.yml
@@ -33,6 +33,6 @@ requires:
 resources:
   license: http://opensource.org/licenses/gpl-license.php
   repository: https://github.com/bestpractical/rt-authen-externalauth
-version: '0.24'
+version: '0.25'
 x_module_install_rtx_version: '0.36'
 x_requires_rt: 4.0.0
diff --git a/lib/RT/Authen/ExternalAuth.pm b/lib/RT/Authen/ExternalAuth.pm
index 8b27bb6..d4dc8dd 100644
--- a/lib/RT/Authen/ExternalAuth.pm
+++ b/lib/RT/Authen/ExternalAuth.pm
@@ -1,6 +1,6 @@
 package RT::Authen::ExternalAuth;
 
-our $VERSION = '0.24';
+our $VERSION = '0.25';
 
 =head1 NAME
 

-----------------------------------------------------------------------