[Bps-public-commit] rt-extension-automaticassignment branch, master, updated. ebe53c8a949e07f673e5151e0954c4f1635e5458

[Shawn Moore]

The branch, master has been updated
       via  ebe53c8a949e07f673e5151e0954c4f1635e5458 (commit)
      from  d4dc9439f9fc2f542eb639faec634bf319688061 (commit)

Summary of changes:
 html/Admin/Queues/Elements/Filter/MemberOfRole              | 2 +-
 lib/RT/Extension/AutomaticAssignment/Chooser/TimeLeft.pm    | 2 +-
 lib/RT/Extension/AutomaticAssignment/Filter/MemberOfRole.pm | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit ebe53c8a949e07f673e5151e0954c4f1635e5458
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Aug 17 22:10:34 2016 +0000

    More small fallout

diff --git a/html/Admin/Queues/Elements/Filter/MemberOfRole b/html/Admin/Queues/Elements/Filter/MemberOfRole
index add03b8..03731e0 100644
--- a/html/Admin/Queues/Elements/Filter/MemberOfRole
+++ b/html/Admin/Queues/Elements/Filter/MemberOfRole
@@ -12,7 +12,7 @@
 % }
 % if ($custom_roles) {
 % while (my $role = $custom_roles->Next) {
-<option <% ($config->{role}||0) == $role->Id ? "selected" : "" %> value="<% $role->Id %>"><% $role->Name %></option>
+<option <% ($config->{role}||0) eq $role->Id ? "selected" : "" %> value="<% $role->Id %>"><% $role->Name %></option>
 % }
 % }
 </select>
diff --git a/lib/RT/Extension/AutomaticAssignment/Chooser/TimeLeft.pm b/lib/RT/Extension/AutomaticAssignment/Chooser/TimeLeft.pm
index 67f463f..e070966 100644
--- a/lib/RT/Extension/AutomaticAssignment/Chooser/TimeLeft.pm
+++ b/lib/RT/Extension/AutomaticAssignment/Chooser/TimeLeft.pm
@@ -17,7 +17,7 @@ sub ChooseOwnerForTicket {
 
     my %timeleft_by_owner;
     while (my $ticket = $tickets->Next) {
-        next if $ticket->Owner = RT->Nobody->id;
+        next if $ticket->Owner == RT->Nobody->id;
         my $time_left = $ticket->TimeLeft || ($ticket->TimeEstimated - $ticket->TimeWorked);
         next if $time_left < 0;
 
diff --git a/lib/RT/Extension/AutomaticAssignment/Filter/MemberOfRole.pm b/lib/RT/Extension/AutomaticAssignment/Filter/MemberOfRole.pm
index a9c2028..34268ae 100644
--- a/lib/RT/Extension/AutomaticAssignment/Filter/MemberOfRole.pm
+++ b/lib/RT/Extension/AutomaticAssignment/Filter/MemberOfRole.pm
@@ -18,7 +18,7 @@ sub FilterOwnersForTicket {
         $ticket_group = $ticket->RoleGroup($role);
         $queue_group = $ticket->QueueObj->RoleGroup($role);
     }
-    elsif (RT::Handle::cmp_version($RT::VERSION,'4.4.0') >= 0) {
+    elsif (RT::Handle::cmp_version($RT::VERSION,'4.4.0') < 0) {
         die "Unable to filter MemberOfRole role '$role'; custom roles require RT 4.4 or greater.";
     }
     else {

-----------------------------------------------------------------------