[Rt-commit] r8805 - in rt/branches/3.7-EXPERIMENTAL: .
ruz at bestpractical.com
ruz at bestpractical.com
Tue Aug 28 14:47:29 EDT 2007
Author: ruz
Date: Tue Aug 28 14:47:28 2007
New Revision: 8805
Modified:
rt/branches/3.7-EXPERIMENTAL/ (props changed)
rt/branches/3.7-EXPERIMENTAL/lib/RT/Test.pm
Log:
r8750 at cubic-pc (orig r8749): ruz | 2007-08-28 01:48:12 +0400
* my $x = ... unless ...; is not that good idea
Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Test.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Test.pm (original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Test.pm Tue Aug 28 14:47:28 2007
@@ -245,11 +245,11 @@
my @fields = qw(CorrespondAddress CommentAddress);
foreach my $field ( @fields ) {
next unless exists $args{ $field };
+ next if $args{ $field } eq $obj->$field;
no warnings 'uninitialized';
my $method = 'Set'. $field;
- my ($val, $msg) = $obj->$method( $args{ $field } )
- unless $args{ $field } eq $obj->$field;
+ my ($val, $msg) = $obj->$method( $args{ $field } );
die "$msg" unless $val;
}
}
More information about the Rt-commit
mailing list