[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-628-g47cc699

[Jesse Vincent]

The branch, 3.9-trunk has been updated
       via  47cc699ac5693df05a5c03ebb2dbab3ada4d4948 (commit)
       via  1686aa7aa168edda5c8f11a1772150bd0c85b323 (commit)
       via  5c04e16960383adc811fd0efaf1fa49420018da1 (commit)
      from  49f603ddce392b4bf9cad5ca038a9cfbc51b149e (commit)

Summary of changes:
 lib/RT/Test/Web.pm            |    5 +----
 share/html/Ticket/Create.html |    3 +--
 t/web/gnupg-outgoing.t        |    8 +++-----
 3 files changed, 5 insertions(+), 11 deletions(-)

- Log -----------------------------------------------------------------
commit 5c04e16960383adc811fd0efaf1fa49420018da1
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Mon Aug 30 14:10:10 2010 -0400

    make the ticket creation helper not do extra homepage loads. saves 10%
    on RT's longest testfile t/web/gnupg-outgoing.t

diff --git a/lib/RT/Test/Web.pm b/lib/RT/Test/Web.pm
index feff736..5761f7c 100644
--- a/lib/RT/Test/Web.pm
+++ b/lib/RT/Test/Web.pm
@@ -152,10 +152,7 @@ sub goto_create_ticket {
         die "not yet implemented";
     }
 
-    $self->get('/');
-    $self->form_name('CreateTicketInQueue');
-    $self->select( 'Queue', $id );
-    $self->submit;
+    $self->get($self->rt_base_url . '/Ticket/Create.html?Queue='.$id);
 
     return 1;
 }

commit 1686aa7aa168edda5c8f11a1772150bd0c85b323
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Mon Aug 30 14:10:46 2010 -0400

    localize a variable in Create.html

diff --git a/share/html/Ticket/Create.html b/share/html/Ticket/Create.html
index 6932bd8..098f1b8 100755
--- a/share/html/Ticket/Create.html
+++ b/share/html/Ticket/Create.html
@@ -274,9 +274,8 @@ $m->callback( CallbackName => "Init", ARGSRef => \%ARGS );
 my $Queue = $ARGS{Queue};
 $session{DefaultQueue} = $Queue;
 
-my $CloneTicketObj;
 if ($CloneTicket) {
-    $CloneTicketObj = RT::Ticket->new( $session{CurrentUser} );
+    my $CloneTicketObj = RT::Ticket->new( $session{CurrentUser} );
     $CloneTicketObj->Load($CloneTicket)
         or Abort( loc("Ticket could not be loaded") );
 

commit 47cc699ac5693df05a5c03ebb2dbab3ada4d4948
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Mon Aug 30 14:39:42 2010 -0400

    When t/web/gnupg_outgoing.t does a reply, avoid a full ticket page load.

diff --git a/t/web/gnupg-outgoing.t b/t/web/gnupg-outgoing.t
index b4a741a..9eb56f4 100644
--- a/t/web/gnupg-outgoing.t
+++ b/t/web/gnupg-outgoing.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 492;
+use RT::Test tests => 456;
 
 plan skip_all => 'GnuPG required.'
     unless eval 'use GnuPG::Interface; 1';
@@ -94,8 +94,7 @@ diag "check in read-only mode that queue's props influence create/update ticket
 
     foreach my $variant ( @variants ) {
         set_queue_crypt_options( %$variant );
-        $m->goto_ticket( $id );
-        $m->follow_link_ok({text => 'Reply'}, '-> reply');
+        $m->get( $m->rt_base_url . "/Ticket/Update.html?Action=Respond&id=$id" );
         $m->form_number(3);
         if ( $variant->{'Encrypt'} ) {
             ok $m->value('Encrypt', 2), "encrypt tick box is checked";
@@ -283,8 +282,7 @@ sub update_ticket {
 
     RT::Test->clean_caught_mails;
 
-    ok $m->goto_ticket( $tid ), "UI -> ticket #$tid";
-    $m->follow_link_ok( { text => 'Reply' }, 'ticket -> reply' );
+    $m->get( $m->rt_base_url . "/Ticket/Update.html?Action=Respond&id=$tid" );
     $m->form_number(3);
     $m->field( UpdateContent => 'Some content' );
 

-----------------------------------------------------------------------