[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.7-904-gdc862c9

Shawn Moore sartak at bestpractical.com
Thu Dec 16 14:28:10 EST 2010


The branch, 3.9-trunk has been updated
       via  dc862c93459c19be55a45c40bd085683c93dd0c5 (commit)
      from  23dc2024414c7e67584cd43e33baf224b4e5a4ae (commit)

Summary of changes:
 lib/RT/Dashboard/Mailer.pm |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit dc862c93459c19be55a45c40bd085683c93dd0c5
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Thu Dec 16 14:28:00 2010 -0500

    Better diagnostics for subscription frequency checking

diff --git a/lib/RT/Dashboard/Mailer.pm b/lib/RT/Dashboard/Mailer.pm
index c319d72..f81c54e 100644
--- a/lib/RT/Dashboard/Mailer.pm
+++ b/lib/RT/Dashboard/Mailer.pm
@@ -96,6 +96,7 @@ sub MailDashboards {
             next unless $self->IsSubscriptionReady(
                 %args,
                 Subscription => $subscription,
+                User         => $user,
                 LocalTime    => [$hour, $dow, $dom],
             );
 
@@ -128,6 +129,7 @@ sub IsSubscriptionReady {
     my %args = (
         All          => 0,
         Subscription => undef,
+        User         => undef,
         LocalTime    => [0, 0, 0],
         @_,
     );
@@ -146,7 +148,7 @@ sub IsSubscriptionReady {
 
     my ($hour, $dow, $dom) = @{ $args{LocalTime} };
 
-    $RT::Logger->debug("Checking against subscription with frequency $sub_frequency, hour $sub_hour, dow $sub_dow, dom $sub_dom, fow $sub_fow");
+    $RT::Logger->debug("Checking against subscription " . $subscription->Id . " for " . $args{User}->Name . " with frequency $sub_frequency, hour $sub_hour, dow $sub_dow, dom $sub_dom, fow $sub_fow, counter $counter");
 
     return 0 if $sub_frequency eq 'never';
 
@@ -181,6 +183,8 @@ sub IsSubscriptionReady {
         return 1;
     }
 
+    $RT::Logger->debug("Invalid subscription frequency $sub_frequency for " . $args{User}->Name);
+
     # unknown frequency type, bail out
     return 0;
 }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list