[Rt-commit] rt branch, 4.2/link-display, created. rt-4.1.13-283-gf097807

[Alex Vandiver]

The branch, 4.2/link-display has been created
        at  f0978076e23b8fc4bb1da9a57b7411b6eb6b1d5c (commit)

- Log -----------------------------------------------------------------
commit f0978076e23b8fc4bb1da9a57b7411b6eb6b1d5c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Jul 9 15:31:52 2013 -0400

    Avoid attempting to nest <a> tags with links and ShowUser
    
    ShowUser now links to the user, which interacts poorly with being inside
    the <a href="<% $href %>"> of the thing we are trying to link to.
    Rather than link to [ticket, owner, ticket], move the owner to the end
    of the line, where it does not occupy such prime link real-estate.

diff --git a/share/html/Elements/ShowLink b/share/html/Elements/ShowLink
index 9593230..c7ef953 100644
--- a/share/html/Elements/ShowLink
+++ b/share/html/Elements/ShowLink
@@ -45,20 +45,17 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<a href="<% $href %>">
 % my $member = $URI->Object;
 % if (blessed($member) && $member->isa("RT::Ticket")) {
 % my $inactive = $member->QueueObj->IsInactiveStatus($member->Status);
 
 <span class="<% $inactive ? 'ticket-inactive' : '' %>">
-
-<%$member->Id%>: (<& /Elements/ShowUser, User => $member->OwnerObj &>) <%$member->Subject || ''%> [<% loc($member->Status) %>]
+<a href="<% $href %>"><%$member->Id%>: <%$member->Subject || ''%> [<% loc($member->Status) %>]</a> (<& /Elements/ShowUser, User => $member->OwnerObj &>)
 </span>
 
 % } else {
-<%$URI->AsString%>
+<a href="<% $href %>"><%$URI->AsString%></a>
 % }
-</a>
 <%ARGS>
 $URI => undef
 </%ARGS>

-----------------------------------------------------------------------