[Rt-commit] rt branch, 4.2/link-display, repushed
Alex Vandiver
alexmv at bestpractical.com
Wed Jul 17 22:32:56 EDT 2013
The branch 4.2/link-display was deleted and repushed:
was da32c52a877329038b030b5738a06ed831c87882
now f0978076e23b8fc4bb1da9a57b7411b6eb6b1d5c
1: da32c52 ! 1: f097807 Avoid attempting to nest <a> tags with links and ShowUser
@@ -2,12 +2,10 @@
Avoid attempting to nest <a> tags with links and ShowUser
- ShowUser now links to the user, which interacts poorly with beig inside
+ ShowUser now links to the user, which interacts poorly with being inside
the <a href="<% $href %>"> of the thing we are trying to link to.
-
- Trailing "\" have been added such that Mason keeps the output on one
- line. This is easier than fixing tests to look for results across one
- or two newlines but not across <span> elements.
+ Rather than link to [ticket, owner, ticket], move the owner to the end
+ of the line, where it does not occupy such prime link real-estate.
diff --git a/share/html/Elements/ShowLink b/share/html/Elements/ShowLink
--- a/share/html/Elements/ShowLink
@@ -22,11 +20,9 @@
% my $inactive = $member->QueueObj->IsInactiveStatus($member->Status);
<span class="<% $inactive ? 'ticket-inactive' : '' %>">
-
+-
-<%$member->Id%>: (<& /Elements/ShowUser, User => $member->OwnerObj &>) <%$member->Subject || ''%> [<% loc($member->Status) %>]
-+<a href="<% $href %>"><%$member->Id%>:</a> \
-+(<& /Elements/ShowUser, User => $member->OwnerObj &>) \
-+<a href="<% $href %>"><%$member->Subject || ''%> [<% loc($member->Status) %>]</a>
++<a href="<% $href %>"><%$member->Id%>: <%$member->Subject || ''%> [<% loc($member->Status) %>]</a> (<& /Elements/ShowUser, User => $member->OwnerObj &>)
</span>
% } else {
More information about the Rt-commit
mailing list