[Rt-commit] rt branch, 4.2/articles-setup-warning-bugfix, updated. rt-4.2.2-17-gf4963b4

[Wallace Reis]

The branch, 4.2/articles-setup-warning-bugfix has been updated
       via  f4963b47b3beb6556a76fc88f5af639c5949e9cd (commit)
       via  88265e1209e01fa813f331b457f3eb8f1b74a6af (commit)
      from  adcb24554f6d24e1488f7a957289d07545bc249d (commit)

Summary of changes:
 .gitignore                              |  1 +
 share/html/Articles/Elements/NeedsSetup |  2 +-
 share/html/Search/Results.html          |  2 +-
 share/static/css/rudder/forms.css       | 12 +++++++++---
 4 files changed, 12 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit 88265e1209e01fa813f331b457f3eb8f1b74a6af
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Mon Feb 10 19:37:41 2014 -0200

    Add local::lib's dir to .gitignore

diff --git a/.gitignore b/.gitignore
index 88c9700..7b9d3fa 100644
--- a/.gitignore
+++ b/.gitignore
@@ -50,3 +50,4 @@
 *~
 *.swp
 *.swo
+local-lib

commit f4963b47b3beb6556a76fc88f5af639c5949e9cd
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Tue Feb 11 13:46:04 2014 -0200

    Issues #28636: Articles setup warning appearance
    
    The commit adcb24554 just fixed the issue for the title part of
    the titlebox. Thus, we need to fix the issue with the box itself
    extending outside of the gray borders.
    
    The issue was introduced in 61e7290e when the theme was created
    which seems to be an attempt to style the display of simple error
    msgs rendered by Elements/Error which is not in the titltebox
    context.
    
    The fix here was to make the pages using a titlebox to display an
    error msg to use a different error class than just "error", that is,
    now called "error-titlebox".

diff --git a/share/html/Articles/Elements/NeedsSetup b/share/html/Articles/Elements/NeedsSetup
index 2dc7e52..edaf043 100644
--- a/share/html/Articles/Elements/NeedsSetup
+++ b/share/html/Articles/Elements/NeedsSetup
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 %# Stupidly long lines because our extract-message-catalog doesn't handle multiple lines!
-<&|/Widgets/TitleBox, id => "articles-needs-setup", class => "error", title => "Setup needed" &>
+<&|/Widgets/TitleBox, id => "articles-needs-setup", class => "error-titlebox", title => "Setup needed" &>
 <p><&|/l_unsafe, qq[<a href="@{[RT->Config->Get("WebPath")]}/Admin/Articles/">], '</a>' &>Before Articles can be used, your RT administrator must [_1]create Classes[_2], apply Article custom fields to them, and grant users rights on the classes and CFs.</&></p>
 <p><&|/l_unsafe, qq[<a href="http://bestpractical.com/rt/docs/$RT::MAJOR_VERSION.$RT::MINOR_VERSION/customizing/articles_introduction.html">], qq[<a href="http://bestpractical.com/rt/docs/$RT::MAJOR_VERSION.$RT::MINOR_VERSION/">], '</a>' &>An [_1]introduction to getting started with articles[_3] is available from [_2]Best Practical's online documentation[_3].</&></p>
 </&>
diff --git a/share/html/Search/Results.html b/share/html/Search/Results.html
index 8571f92..5bff095 100644
--- a/share/html/Search/Results.html
+++ b/share/html/Search/Results.html
@@ -55,7 +55,7 @@
 
 % unless ($ok) {
 %    $msg =~ s{ at .*? line .*}{}s;
-<&| /Widgets/TitleBox, title => loc("Error"), class => "error" &>
+<&| /Widgets/TitleBox, title => loc("Error"), class => "error-titlebox" &>
 <&|/l_unsafe, "<i>".$m->interp->apply_escapes($msg, "h")."</i>" &>There was an error parsing your search query: [_1].  Your RT admin can find more information in the error logs.</&>
 </&>
 % } else {
diff --git a/share/static/css/rudder/forms.css b/share/static/css/rudder/forms.css
index b33cb66..9f7fc1f 100644
--- a/share/static/css/rudder/forms.css
+++ b/share/static/css/rudder/forms.css
@@ -2,7 +2,7 @@
    duplicate properties. */
 
 div.results .titlebox,
-div.error div.error {
+div.error-titlebox {
     border: none;
     background: none;
     font-weight: bold;
@@ -20,14 +20,20 @@ div.results .titlebox-title .left {
     border-width: 1px 1px 0 1px;
 }
 
-div.error .titlebox-title span.left {
+div.error-titlebox .titlebox-title span.left {
     border: none;
     border-right: 2px solid #b00;
     margin-left: 0;
     padding-left: 2.3em;
+    background-color: #f00;
+    color: #fff;
+}
+
+div.error-titlebox .titlebox-content {
+    background-color: #fcc;
+    padding: 1em;
 }
 
-div.error .titlebox-content,
 div#body>div.error {
     background-color: #fcc;
     padding: 1em;

-----------------------------------------------------------------------