[Rt-commit] rt branch, 4.2/articles-setup-warning, created. rt-4.2.2-15-g6d1a4d7

[Wallace Reis]

The branch, 4.2/articles-setup-warning has been created
        at  6d1a4d71fb830d053d513e47743cc8dc8a131d8e (commit)

- Log -----------------------------------------------------------------
commit 6d1a4d71fb830d053d513e47743cc8dc8a131d8e
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Fri Feb 7 03:34:26 2014 -0800

    Issues #28636: Articles setup warning appearance
    
    The issue was introduced in 61e7290e when the theme was created
    which seems to be an attempt to style the display of simple error
    msgs rendered by Elements/Error which is not in the titltebox
    context.
    
    The fix here was to make the pages using a titlebox to display an
    error msg to use a different error class than just "error", that is,
    now called "error-titlebox".

diff --git a/share/html/Articles/Elements/NeedsSetup b/share/html/Articles/Elements/NeedsSetup
index 2dc7e52..edaf043 100644
--- a/share/html/Articles/Elements/NeedsSetup
+++ b/share/html/Articles/Elements/NeedsSetup
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 %# Stupidly long lines because our extract-message-catalog doesn't handle multiple lines!
-<&|/Widgets/TitleBox, id => "articles-needs-setup", class => "error", title => "Setup needed" &>
+<&|/Widgets/TitleBox, id => "articles-needs-setup", class => "error-titlebox", title => "Setup needed" &>
 <p><&|/l_unsafe, qq[<a href="@{[RT->Config->Get("WebPath")]}/Admin/Articles/">], '</a>' &>Before Articles can be used, your RT administrator must [_1]create Classes[_2], apply Article custom fields to them, and grant users rights on the classes and CFs.</&></p>
 <p><&|/l_unsafe, qq[<a href="http://bestpractical.com/rt/docs/$RT::MAJOR_VERSION.$RT::MINOR_VERSION/customizing/articles_introduction.html">], qq[<a href="http://bestpractical.com/rt/docs/$RT::MAJOR_VERSION.$RT::MINOR_VERSION/">], '</a>' &>An [_1]introduction to getting started with articles[_3] is available from [_2]Best Practical's online documentation[_3].</&></p>
 </&>
diff --git a/share/html/Search/Results.html b/share/html/Search/Results.html
index 8571f92..5bff095 100644
--- a/share/html/Search/Results.html
+++ b/share/html/Search/Results.html
@@ -55,7 +55,7 @@
 
 % unless ($ok) {
 %    $msg =~ s{ at .*? line .*}{}s;
-<&| /Widgets/TitleBox, title => loc("Error"), class => "error" &>
+<&| /Widgets/TitleBox, title => loc("Error"), class => "error-titlebox" &>
 <&|/l_unsafe, "<i>".$m->interp->apply_escapes($msg, "h")."</i>" &>There was an error parsing your search query: [_1].  Your RT admin can find more information in the error logs.</&>
 </&>
 % } else {
diff --git a/share/static/css/rudder/forms.css b/share/static/css/rudder/forms.css
index ff285cd..9f7fc1f 100644
--- a/share/static/css/rudder/forms.css
+++ b/share/static/css/rudder/forms.css
@@ -2,7 +2,7 @@
    duplicate properties. */
 
 div.results .titlebox,
-div.error div.error {
+div.error-titlebox {
     border: none;
     background: none;
     font-weight: bold;
@@ -20,12 +20,20 @@ div.results .titlebox-title .left {
     border-width: 1px 1px 0 1px;
 }
 
-div.error .titlebox-title span.left {
+div.error-titlebox .titlebox-title span.left {
     border: none;
     border-right: 2px solid #b00;
+    margin-left: 0;
+    padding-left: 2.3em;
+    background-color: #f00;
+    color: #fff;
+}
+
+div.error-titlebox .titlebox-content {
+    background-color: #fcc;
+    padding: 1em;
 }
 
-div.error .titlebox-content,
 div#body>div.error {
     background-color: #fcc;
     padding: 1em;

-----------------------------------------------------------------------