[Rt-commit] rt branch, 4.2/log-unlink-errors, created. rt-4.2.12-156-ga7342b4

Jim Brandt jbrandt at bestpractical.com
Wed Jun 29 16:04:18 EDT 2016


The branch, 4.2/log-unlink-errors has been created
        at  a7342b463fd88bf354678edc0c144cee9804fcbe (commit)

- Log -----------------------------------------------------------------
commit a7342b463fd88bf354678edc0c144cee9804fcbe
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Wed Jun 29 16:02:45 2016 -0400

    Log failure to unlink temp file after email parse
    
    Fixes: I#32142

diff --git a/lib/RT/EmailParser.pm b/lib/RT/EmailParser.pm
index 0a046c8..dd80e57 100644
--- a/lib/RT/EmailParser.pm
+++ b/lib/RT/EmailParser.pm
@@ -123,7 +123,8 @@ sub SmartParseMIMEEntityFromScalar {
             if ( -f $temp_file ) {
 
                 my $entity = $self->ParseMIMEEntityFromFile( $temp_file, $args{'Decode'}, $args{'Exact'} );
-                unlink($temp_file);
+                unlink($temp_file)
+                    or RT->Logger->error("Unable to delete temp file $temp_file, error: $!");
                 return $entity;
             }
         }

-----------------------------------------------------------------------


More information about the rt-commit mailing list