[Rt-commit] rt branch, 4.2/onetime-checkbox-wrapping, created. rt-4.2.13-55-g05ddb18

[Dustin Collins]

The branch, 4.2/onetime-checkbox-wrapping has been created
        at  05ddb1844560bc8153e9ccf52e7956c506fc33c7 (commit)

- Log -----------------------------------------------------------------
commit 05ddb1844560bc8153e9ccf52e7956c506fc33c7
Author: Dustin Collins <strega at bestpractical.com>
Date:   Wed Sep 7 07:33:47 2016 -0400

    Prevent Cc checkbox and label from wrapping independently
    
    One-Time Cc and Bcc checkboxes wrap independently of their associated
    label making it difficult to determine which input belongs to which
    label. In order to maintain a more clear visual association, both input
    and label elements are wrapped in a span, styled as nowrap in base/ticket-form.css.
    
    Fixes: I#32117

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index 6101139..bb65553 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -55,6 +55,7 @@
 <i class="label">(<&|/l&>check to add</&>)</i>
 %}
 %foreach my $addr ( @one_time_Ccs ) {
+<span class="ticket-update-suggested-cc">
 <input
     id="UpdateCc-<%$addr%>"
     name="UpdateCc-<%$addr%>"
@@ -64,6 +65,7 @@
     onClick="checkboxToInput('UpdateCc', <% "UpdateCc-$addr" |n,j%>, <%$clean_addr|n,j%> );"
     <% $ARGS{'UpdateCc-'.$addr} ? 'checked="checked"' : ''%> >
       <label for="UpdateCc-<%$addr%>"><& /Elements/ShowUser, Address => $txn_addresses{$addr}&></label>
+</span>
 %}
 </td></tr>
 <tr><td class="label"><&|/l&>One-time Bcc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateBcc', Size => undef, Default => $ARGS{UpdateBcc}, AutocompleteMultiple => 1 &><br />
@@ -71,6 +73,7 @@
 <i class="label">(<&|/l&>check to add</&>)</i>
 %}
 %foreach my $addr ( @one_time_Ccs ) {
+<span class="ticket-update-suggested-cc">
 <input
     id="UpdateBcc-<%$addr%>"
     name="UpdateBcc-<%$addr%>"
@@ -80,6 +83,7 @@
     onClick="checkboxToInput('UpdateBcc', <% "UpdateBcc-$addr" |n,j%>, <%$clean_addr|n,j%> );"
     <% $ARGS{'UpdateBcc-'.$addr} ? 'checked="checked"' : ''%> >
       <label for="UpdateBcc-<%$addr%>"><& /Elements/ShowUser, Address => $txn_addresses{$addr}&></label>
+</span>
 %}
 </td></tr>
 <%args>
diff --git a/share/static/css/base/ticket-form.css b/share/static/css/base/ticket-form.css
index 11d1fdd..9462fe6 100644
--- a/share/static/css/base/ticket-form.css
+++ b/share/static/css/base/ticket-form.css
@@ -27,6 +27,10 @@
     list-style: none;
 }
 
+.ticket-update-suggested-cc {
+    white-space: nowrap;
+}
+
 iframe.richtext-editor {
     background-color: white !important;
 }

-----------------------------------------------------------------------