[Rt-commit] rt branch, 4.2/onetime-checkbox-wrapping, repushed

Dustin Collins strega at bestpractical.com
Mon Sep 12 11:56:10 EDT 2016


The branch 4.2/onetime-checkbox-wrapping was deleted and repushed:
       was 840fbe67b5ac6e28d95af119cb4ea4fc4ecf6651
       now 05ddb1844560bc8153e9ccf52e7956c506fc33c7

1:  840fbe6 ! 1:  05ddb18 Prevent Cc checkbox and label from wrapping independently
    @@ -2,9 +2,10 @@
     
         Prevent Cc checkbox and label from wrapping independently
         
    -    One-Time Cc and Bcc checkboxes wrap independently of their associated label making it difficult to determine which input belongs to which label. In order to maintain a more clear visual association, both input and label elements are wrapped in a nowrap styled span.
    -    
    -    Because this association should be maintained across themes, the style is defined inline as an html attribute.
    +    One-Time Cc and Bcc checkboxes wrap independently of their associated
    +    label making it difficult to determine which input belongs to which
    +    label. In order to maintain a more clear visual association, both input
    +    and label elements are wrapped in a span, styled as nowrap in base/ticket-form.css.
         
         Fixes: I#32117
     
    @@ -15,7 +16,7 @@
      <i class="label">(<&|/l&>check to add</&>)</i>
      %}
      %foreach my $addr ( @one_time_Ccs ) {
    -+<span style="white-space: nowrap;">
    ++<span class="ticket-update-suggested-cc">
      <input
          id="UpdateCc-<%$addr%>"
          name="UpdateCc-<%$addr%>"
    @@ -31,7 +32,7 @@
      <i class="label">(<&|/l&>check to add</&>)</i>
      %}
      %foreach my $addr ( @one_time_Ccs ) {
    -+<span style="white-space: nowrap;">
    ++<span class="ticket-update-suggested-cc">
      <input
          id="UpdateBcc-<%$addr%>"
          name="UpdateBcc-<%$addr%>"
    @@ -43,3 +44,18 @@
      %}
      </td></tr>
      <%args>
    +
    +diff --git a/share/static/css/base/ticket-form.css b/share/static/css/base/ticket-form.css
    +--- a/share/static/css/base/ticket-form.css
    ++++ b/share/static/css/base/ticket-form.css
    +@@
    +     list-style: none;
    + }
    + 
    ++.ticket-update-suggested-cc {
    ++    white-space: nowrap;
    ++}
    ++
    + iframe.richtext-editor {
    +     background-color: white !important;
    + }



More information about the rt-commit mailing list