[Rt-commit] rt branch, 4.6/fix-subject-overflow, updated. rt-4.4.4-577-g86a1cf5aa1

? sunnavy sunnavy at bestpractical.com
Mon Dec 30 14:10:23 EST 2019


The branch, 4.6/fix-subject-overflow has been updated
       via  86a1cf5aa11d8f946ddc09a48daae73942ec2524 (commit)
       via  8e49f24a3b4561867a8eac1f3a1f5c518168dac6 (commit)
      from  cfdff464bf19532008a722d3ec060cc0b22f28ec (commit)

Summary of changes:
 share/static/css/elevator-light/layout.css | 3 ++-
 share/static/css/elevator-light/login.css  | 6 ++----
 share/static/css/elevator-light/nav.css    | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

- Log -----------------------------------------------------------------
commit 8e49f24a3b4561867a8eac1f3a1f5c518168dac6
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Dec 31 00:24:52 2019 +0800

    Drop the workaround of a weird issue on really-old version of chrome
    
    It was initially a fix for aileron theme(which is dropped) nearly a
    decade ago.  I can't reproduce this in recent chrome versions. Removing
    this so we can have a clean base for nav-menu's vertical position adjust.

diff --git a/share/static/css/elevator-light/login.css b/share/static/css/elevator-light/login.css
index 0440293a87..5f10ef7f39 100644
--- a/share/static/css/elevator-light/login.css
+++ b/share/static/css/elevator-light/login.css
@@ -15,9 +15,7 @@
     position: absolute;
     z-index: 9999;
     left: 0;
-    /* This avoids a very weird bug in Chrome where opening a select causes a
-     * hover event at (0,0), which will be over top of the menu sometimes */
-    top: 1px;
+    top: 0;
 }
 
 #quick-personal #not-logged-in {
diff --git a/share/static/css/elevator-light/nav.css b/share/static/css/elevator-light/nav.css
index 8277ea1f4d..a072342fbd 100644
--- a/share/static/css/elevator-light/nav.css
+++ b/share/static/css/elevator-light/nav.css
@@ -68,7 +68,7 @@ ul.sf-menu li {
 
 #main-navigation {
     position: absolute;
-    top: 1px;
+    top: 0;
     left: 0;
     z-index: 9999;
     text-color: #000;

commit 86a1cf5aa11d8f946ddc09a48daae73942ec2524
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Dec 30 23:28:45 2019 +0800

    Vertically align header elements including menus/topactions/subject
    
    As we reduced height of headers a little bit, we need to adjust
    menu/subject accordingly. Note that most items were not vertically
    aligned previously anyway.

diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index bd25fb273c..5b2449a152 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -124,12 +124,13 @@ div#header {
     border-bottom-color: #547CCC;
     border-bottom-width: 2px;
     border-bottom-style: solid;
+    padding-bottom: 2px;
 }
 
 div#header h1 {
     font-size: 1.4em;
     padding-left: 2em;
-    padding-top: 5px;
+    padding-top: 2px;
     display: inline-block;
 }
 
diff --git a/share/static/css/elevator-light/login.css b/share/static/css/elevator-light/login.css
index 5f10ef7f39..0242c57fc0 100644
--- a/share/static/css/elevator-light/login.css
+++ b/share/static/css/elevator-light/login.css
@@ -20,7 +20,7 @@
 
 #quick-personal #not-logged-in {
     display: block;
-    padding-top: 0.5em;
+    margin-top: 0.75em;
     padding-left: 1em;
 }
 
diff --git a/share/static/css/elevator-light/nav.css b/share/static/css/elevator-light/nav.css
index a072342fbd..b82532a1dc 100644
--- a/share/static/css/elevator-light/nav.css
+++ b/share/static/css/elevator-light/nav.css
@@ -284,7 +284,7 @@ ul.sf-menu li {
 .create-narrow { display: none; }
 
 #app-nav {
-    padding: 0.5rem;
+    padding: 0.4rem;
 }
 
 /* to stop a "flash" of an unstyled menu on an older browser,  hide the menu until superfish has initialized it */

-----------------------------------------------------------------------


More information about the rt-commit mailing list