[Rt-commit] rt branch, 4.6/squeeze-multi-lined-search-result, created. rt-4.4.4-725-g522cf4180f

? sunnavy sunnavy at bestpractical.com
Thu Feb 6 13:25:44 EST 2020


The branch, 4.6/squeeze-multi-lined-search-result has been created
        at  522cf4180fe0a129ad91195f9e864a7b32a19bc9 (commit)

- Log -----------------------------------------------------------------
commit fb0a11df0effd7c6c32e3156a485cf8698181330
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Tue Jan 14 15:22:10 2020 -0600

    Squeeze multi-lined search results
    
    The UI now is more clear and also could render more records, which is
    similar to 4.4.  Note that padding-top and padding-bottom are not
    balanced in 4.4, which is a little bit weird, this commits keeps
    balanced paddings for each record.

diff --git a/share/static/css/elevator-light/collection.css b/share/static/css/elevator-light/collection.css
index 6ce4390da7..3f508c5d42 100644
--- a/share/static/css/elevator-light/collection.css
+++ b/share/static/css/elevator-light/collection.css
@@ -25,3 +25,28 @@
     font-size: smaller;
     font-weight: normal;
 }
+
+/* squeeze multiple-lined headers */
+tr.collection-as-table+tr.collection-as-table th {
+    padding-top: 0;
+}
+
+/* squeeze multiple-lined records */
+tr:first-of-type.oddline .collection-as-table,
+tr:first-of-type.evenline .collection-as-table {
+    padding-top: 0.5rem;
+    padding-bottom: 0.15rem;
+}
+
+tr.oddline+.oddline .collection-as-table,
+tr.evenline+.evenline .collection-as-table {
+    border: none;
+    padding-top: 0;
+    padding-bottom: 0.15rem;
+}
+
+/* add td here to have a bit higher precedence */
+tr:last-of-type.oddline td.collection-as-table,
+tr:last-of-type.evenline td.collection-as-table {
+    padding-bottom: 0.5rem;
+}

commit 522cf4180fe0a129ad91195f9e864a7b32a19bc9
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Fri Jan 17 16:12:14 2020 -0600

    Make article list on overview page be similar to search results
    
    Previously the looking wasn't that good.  This commit mainly makes it
    pretty and also consistent.

diff --git a/share/html/Articles/Elements/NewestArticles b/share/html/Articles/Elements/NewestArticles
index f0fa4c7001..48b5f34935 100644
--- a/share/html/Articles/Elements/NewestArticles
+++ b/share/html/Articles/Elements/NewestArticles
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <& /Widgets/TitleBoxStart, title => loc("[_1] newest articles", $rows), bodyclass=> '' &>
 
-<div class="form-row">
+<div class="form-row article-headers">
   <div class="col-md-auto label text-right">
     <&|/l&>#</&>
   </div>
@@ -63,12 +63,12 @@
 </div>
 % while (my $Article = $MyArticles->Next) {
 % $i++;
-<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
+<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row article-metadata">
   <div class="col-md-auto value text-right">
-    <span class="current-value"><%$Article->Id%></span>
+    <span class="current-value font-weight-bold"><%$Article->Id%></span>
   </div>
   <div class="col-md-4 value text-left">
-    <span class="current-value"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
+    <span class="current-value font-weight-bold"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
   </div>
   <div class="col-md-4 value text-left">
     <span class="current-value"><%$Article->CreatorObj->Name%></span>
@@ -77,7 +77,7 @@
     <span class="current-value">[<a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Edit.html?id=<%$Article->Id%>"><&|/l&>Update</&></a>]</span>
   </div>
 </div>
-<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
+<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row article-summary">
   <div class="col-md-11 col-md-offset-1">
     <span class="current-value"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
   </div>
diff --git a/share/html/Articles/Elements/UpdatedArticles b/share/html/Articles/Elements/UpdatedArticles
index f69328033a..405239f86f 100644
--- a/share/html/Articles/Elements/UpdatedArticles
+++ b/share/html/Articles/Elements/UpdatedArticles
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <& /Widgets/TitleBoxStart, title => loc("[_1] most recently updated articles", $rows), bodyclass=> '' &>
 
-<div class="form-row">
+<div class="form-row article-headers">
   <div class="col-md-auto label text-right">
     <&|/l&>#</&>
   </div>
@@ -64,12 +64,12 @@
 
 % while (my $Article = $MyArticles->Next) {
 % $i++;
-<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
+<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row article-metadata">
   <div class="col-md-auto value text-right">
-    <span class="current-value"><%$Article->Id%></span>
+    <span class="current-value font-weight-bold"><%$Article->Id%></span>
   </div>
   <div class="col-md-4 value text-left">
-    <span class="current-value"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
+    <span class="current-value font-weight-bold"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
   </div>
   <div class="col-md-4 value text-left">
     <span class="current-value"><%$Article->CreatorObj->Name%></span>
@@ -79,7 +79,7 @@
   </div>
 </div>
 
-<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
+<div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row article-summary">
   <div class="col-md-11 col-md-offset-1">
     <span class="current-value"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
   </div>
diff --git a/share/static/css/elevator-light/articles.css b/share/static/css/elevator-light/articles.css
index 1e0d907eab..7e4a0f8a3f 100644
--- a/share/static/css/elevator-light/articles.css
+++ b/share/static/css/elevator-light/articles.css
@@ -1,3 +1,23 @@
 #articles-needs-setup a {
     text-decoration: underline;
 }
+
+#comp-Articles .form-row.article-headers,
+#comp-Articles .form-row.article-metadata,
+#comp-Articles .form-row.article-summary {
+    margin-top: 0;
+    padding: 0.5rem;
+}
+
+#comp-Articles .form-row.article-metadata {
+    padding-bottom: 0.15rem;
+}
+
+#comp-Articles .form-row.article-summary {
+    padding-top: 0;
+}
+
+#comp-Articles .form-row.article-headers,
+#comp-Articles .form-row.article-summary {
+    border-bottom: 1px solid #dee2e6;
+}

-----------------------------------------------------------------------


More information about the rt-commit mailing list