[Rt-commit] rt branch, 4.6/wide-labels-in-edit-search, created. rt-4.4.4-725-gcea0dca2a1

[? sunnavy]

The branch, 4.6/wide-labels-in-edit-search has been created
        at  cea0dca2a17fb8e057c2c05ba1a39c36605e3d46 (commit)

- Log -----------------------------------------------------------------
commit 0f56e97f40a85837eb0a169ed19d874e5556ce0b
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Feb 7 02:53:30 2020 +0800

    Give labels in EditSearches a bit more space to avoid wrapping
    
    This is to avoid "Load saved search" from wrapping in 1280 screens.
    Even worse, wrapped labels could cause "Load" button in the same row to
    be weirdly tall.

diff --git a/share/html/Search/Elements/EditSearches b/share/html/Search/Elements/EditSearches
index 6bdb77cf5f..211f66041a 100644
--- a/share/html/Search/Elements/EditSearches
+++ b/share/html/Search/Elements/EditSearches
@@ -51,14 +51,14 @@
 % if ( $can_modify ) {
 
 <div class="form-row">
-  <div class="col-md-3 label"><&|/l&>Privacy</&>:</div>
-  <div class="col-md-9">
+  <div class="col-md-4 label"><&|/l&>Privacy</&>:</div>
+  <div class="col-md-8">
 <& SelectSearchObject, Name => 'SavedSearchOwner', Objects => \@Objects, Object => ( $Object && $Object->id ) ? $Object->Object : '' &>
   </div>
 </div>
   <div class="form-row">
-    <div class="col-md-3 label"><&|/l&>Description</&>:</div>
-    <div class="col-md-9 input-group">
+    <div class="col-md-4 label"><&|/l&>Description</&>:</div>
+    <div class="col-md-8 input-group">
       <input type="text" size="25" name="SavedSearchDescription" value="<% $Description || '' %>" class="form-control" />
 % if ($Id ne 'new') {
 % if ( $Dirty ) {
@@ -81,8 +81,8 @@
 
   <hr />
   <div class="form-row">
-    <div class="col-md-3 label"><&|/l&>Load saved search</&>:</div>
-    <div class="col-md-9 input-group">
+    <div class="col-md-4 label"><&|/l&>Load saved search</&>:</div>
+    <div class="col-md-8 input-group">
 <& SelectSearchesForObjects, Name => 'SavedSearchLoad', Objects => \@Objects, SearchType => $Type &>
 <input type="submit" class="button btn btn-primary" value="<% loc('Load') %>" id="SavedSearchLoadSubmit" name="SavedSearchLoadSubmit" />
     </div>

commit cea0dca2a17fb8e057c2c05ba1a39c36605e3d46
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Feb 7 03:09:15 2020 +0800

    Use side-by-side layout only for extra large screens for search chart page
    
    On smaller screens, a few things could be badly wrapped including labels
    in "Saved charts" and selects in "Group by" and "Calculate".
    
    This is also more consistent with search builder.

diff --git a/share/html/Search/Chart.html b/share/html/Search/Chart.html
index 06af5b5e8d..5ee8ceb275 100644
--- a/share/html/Search/Chart.html
+++ b/share/html/Search/Chart.html
@@ -134,7 +134,7 @@ $m->callback( ARGSRef => \%ARGS, QueryArgsRef => \%query );
 <div class="chart-type">
 
 <div class="form-row">
-  <div class="col-md-6">
+  <div class="col-xl-6">
 
 <form method="get" action="<% RT->Config->Get('WebPath') %>/Search/Chart.html">
 <input type="hidden" class="hidden" name="Query" value="<% $query{Query} %>" />
@@ -252,7 +252,7 @@ jQuery(".chart-picture [name=ChartStyleIncludeSQL]").change( updateChartStyle );
     </form>
   </div>
 
-  <div class="col-md-6">
+  <div class="col-xl-6">
     <div class="saved-search">
       <& /Widgets/SavedSearch:show, %ARGS, Action => 'Chart.html', self => $saved_search, Title => loc('Saved charts') &>
     </div>

-----------------------------------------------------------------------