[rt-devel] [PATCH] Make group and keyword ID printing configurable

[Jesse Vincent]

I suspect that the better answer is just to not print them. they don't actually
convey much in the way of useful information. And we're already heavy on config
variables ;) but I do appreciate the patch.


On Tue, Jan 08, 2002 at 11:06:21PM -0800, Blair Zajac wrote:
> The following patch against 2.0.11 adds two new configuration variables to
> config.pm to enable the group and keyword ID to be printed.
> 
> I find them distracting, because the numeric IDs are in different order
> than the alphabetically sorted order.
> 
> The default here is to turn them off.
> 
> The ID can still be determined by examining the URL that clicking on the
> group or keyword would lead to.
> 
> Best,
> Blair
> 
> -- 
> Blair Zajac <blair at orcaware.com>
> Web and OS performance plots - http://www.orcaware.com/orca/
> diff -ru ../rt-2-0-11/etc/config.pm ./etc/config.pm
> --- ../rt-2-0-11/etc/config.pm	Fri Nov  9 14:07:03 2001
> +++ ./etc/config.pm	Tue Jan  8 22:57:30 2002
> @@ -286,6 +286,16 @@
>  # {{{ Web interface configuration
>  
>  
> +# Set this to 1 if the web interface should print the unique numeric
> +# ID before each group name in the [Configuration]/[Groups] web page,
> +# 0 if IDs should not be shown.
> +$WebShowGroupID = 0;
> +
> +# Set this to 1 if the web interface should print the unique numeric
> +# ID before each keyword in the [Configuration]/[Keywords] web page, 0
> +# if IDs should not be shown.
> +$WebShowKeywordID = 0;
> +
>  
>  # Define the directory name to be used for images in rt web
>  # documents.
> diff -ru ../rt-2-0-11/webrt/Admin/Groups/index.html ./webrt/Admin/Groups/index.html
> --- ../rt-2-0-11/webrt/Admin/Groups/index.html	Tue Nov  6 15:06:13 2001
> +++ ./webrt/Admin/Groups/index.html	Tue Jan  8 22:59:23 2002
> @@ -6,8 +6,13 @@
>  
>  Pseudogroups:<BR>
>  <UL>
> -%while ( $Group = $PseudoGroups->Next) {
> -<LI><A HREF="Modify.html?id=<%$Group->id%>"><%$Group->id%>: <%$Group->Name%></a><BR>
> +%while ($Group = $PseudoGroups->Next) {
> +<LI><A HREF="Modify.html?id=<%$Group->id%>">
> +%if ($RT::WebShowGroupID) {
> +  <%$Group->id%>:
> +%}
> +  <%$Group->Name%></a><BR>
> +</LI>
>  %}
>  
>  </UL>
> diff -ru ../rt-2-0-11/webrt/Admin/Keywords/index.html ./webrt/Admin/Keywords/index.html
> --- ../rt-2-0-11/webrt/Admin/Keywords/index.html	Tue Nov  6 15:06:16 2001
> +++ ./webrt/Admin/Keywords/index.html	Tue Jan  8 22:45:06 2002
> @@ -11,7 +11,13 @@
>  
>  
>  % while (my $key = $Keywords->Next) {
> +
> +% if ($RT::WebShowKeywordID) {
>      <LI><%$key->id%>:
> +% } else {
> +    <LI>
> +% }
> +
>  % if ($Edit == $key->id) {
>        <input name="KeyName-<%$key->id%>" value="<%$key->Name%>">
>  	  <input type=submit value="Update">


-- 
http://www.bestpractical.com/products/rt  -- Trouble Ticketing. Free.