[Rt-devel] [PATCH] Perfomance improvement of Tickets->_parser call.

Robert Spier rspier at pobox.com
Wed May 12 13:17:21 EDT 2004


> 1) Get rid from copy of incoming args in _match.
> 2) Decrease _match() calss.
> 	1) $curent = XXX if(_match) sequence changed to if(_match)
> 	{$current = XXX} elsif(_match) sequence in reverse order. So one
> 	_match on loop step.
> 
> 	2) implement $want check before _match, bin logic op surely faster
> 	then (sub call+regexp). This also descrease _match calls.
> 
> 3) base reqexps refactoring. [><=] better then (?:>|<|=).
> 4) another small things.

These are all microoptimizations and I highly doubt they're causing
the time difference you're seeing.  Some of them make the code harder
to read or less consistent, which is a negative.

-R


More information about the Rt-devel mailing list