[Rt-devel] [fsck.com #6964] Bugs in RT 3.4.2 - Query Builder

[Rolf Grossmann]

Rodolfo de Moraes Reis wrote:

> I've been working with RT 3.4.2 since it was released, and in this period, I identified 2 critical bugs in Query Builder Page.
> 
> 1- Error "Can't locate object method "removeChild" via package "root""
> 
> I.e.: I add 2 criteria. After I set 2 others criteria to be added and in the same time I select that 2 (that were added) to be removed and then, when I click in delete button appear this error:
> 
> Can't locate object method "removeChild" via package "root" (perhaps you forgot to load "root"?) at /l/disk1/ccdsin/rt3.4.1/share/html/Search/Build.html line 432.
> context: 	 ... 	 	

Good catch. I've reproduced the bug with rt 3.4.3rc2 and I'm attaching a
patch. I looks to me like the problem occurs because new criteria are
added before the selected ones are deleted. The patch changes that order
(and reloads cached values that may have been deleted).

On the other hand, since the "Add" button has not been pressed, maybe
there should be no added conditions. In that case the whole block could
be made conditional on the "Add" button (and probably the "Search"
button aswell!) and wouldn't need to be moved.

> 2- Change operator AND to OR (or vice versa)
> 
> In a query, I've this scenario:
>   DependedOnBy = '1128'
>   OR id = 755
>   OR Status != 'stalled'
> So, if I try to change the second OR operator (in "OR Status != 'stalled'") to AND, this operation is applied also to the first OR operator (in "OR id = 755") and both are changed to AND. I can bypass this bug (putting some parenthesis using advantage page), although it's "too hard" for end users (you know that ! :))

This is intentional. The "And/Or" button changes the aggregator for all
expressions on the same level. You can't even have different aggregators
on the same level (by editing it that way in the advanced page), because
it is stored in the parent node.

> Someone already had these errors?! Is there a way to fix?! Does the 3.4.3 version solve these problems?!

Hopefully, it will be fixed in the upcoming 3.4.4 release.

Rolf.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rt.patch
Type: text/x-patch
Size: 5566 bytes
Desc: not available
Url : http://lists.bestpractical.com/pipermail/rt-devel/attachments/20050825/303df079/rt.bin