[Rt-devel] RT 3.4.4pre3

[Rolf Grossmann]

Jesse Vincent wrote:
> 
> On Fri, Aug 26, 2005 at 05:06:06PM +0200, Rolf Grossmann wrote:
> 
>>Jesse Vincent wrote:
>>
>>>I know that
>>>there are some additional wrinkles in the query builder that folks have
>>>been finding over the past few days and would love to see patches for
>>>those for RT 3.4.5
>>
>>The one I confirmed contained a patch against 3.4.4rc2 (I believe I had
>>a typo in my mail). 
> 
> I'd kind of wondered. You'd said it was against 3.4.2rc2, which I could
> believe. Interestingly, I can't make RT _crash_ like the original
> poster, though I do get weird results trying to add and delete at the
> same time.

Try adding 2 new items, while also deleting 2. It doesn't "crash" if
you're only adding or deleteing one.

> Someone posted a very strange AND/OR case just yesterday.   

Ok, found it and I can also verify that one. And while I have a simple
fix (attached), that I believe is correct, I'm a little surprised that
parser works as well as it does. ;) Also, the comment for it refers to a
similar parser, which may or may not have a similar problem ... which I
guess I should explain, too ;)

The problem we're trying to fix here stems from the fact that when
building the expression tree, the aggregator is only set together with a
match criteria. However, for every level or brackets, a new aggregator
is created. So for bracketed expressions like ((a and b) or (c and d)),
with a, b, c and d being criteria) the or-aggregator is never set. The
fix I'm proposing moves the assignment of the aggregator to when it's
actually encountered in the expression.

Now, I haven't checked what the other parser is used for, but it really
looks similar. I'll have to check, but maybe you can give me a hint?
Also, if there's a plan to rework the parser (it's the same in 3.5.x),
please let me know.

Rolf.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rt.patch
Type: text/x-patch
Size: 625 bytes
Desc: not available
Url : http://lists.bestpractical.com/pipermail/rt-devel/attachments/20050829/790b92b6/rt.bin