[Rt-devel] FYI Search/Rights.html : The Refactoring!

Jesse Vincent jesse at bestpractical.com
Thu Nov 3 20:38:04 EST 2005

> I've also been looking at that code a while ago (and I've sent a bug fix
> for the search code to this list, but I guess it slipped through the
> cracks ... ;)). 

Do you know about when? Can you reforward a copy to rt-bugs?

> I had to conclude, that those two copies, though quite
> similar, are still working in different ways. While the Search code is
> building a tree for the expression, the TicketSQL code is merely parsing
> it for syntactic correctness while handing it off to
> DBIx::SearchBuilder module (and some undocumented part of it aswell, I
> might add ;)). So I find refactoring that code is not as easy a task as
> it looks.

The search code was forked from the TicketSQL parser by a developer who
didn't fully understand the importance of code reuse. We've started into
cleaning this up, but yeah, it's nontrivial to fix.

> Rolf.


More information about the Rt-devel mailing list