[Rt-devel] FYI Search/Rights.html : The Refactoring!
todd at chaka.net
Thu Nov 3 22:15:10 EST 2005
On Thu, Nov 03, 2005 at 08:38:04PM -0500, Jesse Vincent wrote:
> > I've also been looking at that code a while ago (and I've sent a bug fix
> > for the search code to this list, but I guess it slipped through the
> > cracks ... ;)).
> Do you know about when? Can you reforward a copy to rt-bugs?
> > I had to conclude, that those two copies, though quite
> > similar, are still working in different ways. While the Search code is
> > building a tree for the expression, the TicketSQL code is merely parsing
> > it for syntactic correctness while handing it off to
> > DBIx::SearchBuilder module (and some undocumented part of it aswell, I
> > might add ;)). So I find refactoring that code is not as easy a task as
> > it looks.
> The search code was forked from the TicketSQL parser by a developer who
> didn't fully understand the importance of code reuse. We've started into
> cleaning this up, but yeah, it's nontrivial to fix.
I'm not going there. I just want to get the proof of concept working,
and if we get some of the perl out of the component and into a testing
module, that's a bonus. :)
> > Rolf.
More information about the Rt-devel