[Rt-devel] PATCH: silence warnings Ticket/Elements/EditCustomFields
Jim Meyer
purp at acm.org
Wed Nov 16 19:48:58 EST 2005
Attached.
While there's a bit of a refactor involved toward the end, this diff is
largely just a rework of the indents to be consistent (which makes it
easier to refactor =). I pulled a bunch of "... && ... && ... &&" stuff
out of a <%%> element around the 'SELECTED' line and collapsed the logic
a bit.
I desperately wanted to refactor to eliminate the "if (1)" bit, but I
don't have time to get clear on how the semi-global @levels is being
used. Maybe later.
Cheers!
--j
--
Jim Meyer, Geek at Large purp at acm.org
-------------- next part --------------
--- share/html/Ticket/Elements/EditCustomFields 2005-05-22 15:35:47.000000000 -0700
+++ local/html/Ticket/Elements/EditCustomFields.merge 2005-11-16 15:42:33.000000000 -0800
@@ -48,9 +48,9 @@
<td valign="top" width="50%">
<table>
% my @entry_fields;
-% my $i;
+% my $i = 0;
% my $cfcount = $CustomFields->Count;
% $cfcount++ if ($cfcount % 2) ; # if we have an odd number of
% #custom fields, fudge it so we know where to put in the table break
% while (my $CustomField = $CustomFields->Next()) {
More information about the Rt-devel
mailing list