[Rt-devel] PATCH: silence warnings Admin/Elements/Tabs

Jesse Vincent jesse at bestpractical.com
Wed Nov 16 20:49:14 EST 2005




On Wed, Nov 16, 2005 at 05:47:54PM -0800, Jim Meyer wrote:
> Attached.

I'm betting you have one huge diff of all of these too. Is that actually
the case? We've hit the point where that may be a lot easier ;)


> 
> --j
> -- 
> Jim Meyer, Geek at Large                                    purp at acm.org

> --- share/html/Admin/Elements/Tabs	2005-02-02 08:32:49.000000000 -0800
> +++ local/html/Admin/Elements/Tabs	2005-11-16 17:45:18.000000000 -0800
> @@ -73,9 +73,9 @@
>    # Now let callbacks add their extra tabs
>    $m->comp('/Elements/Callback', tabs => $tabs, %ARGS);
>  
>    foreach my $tab (sort keys %{$tabs}) {
> -    if ($tabs->{$tab}->{'path'} eq $current_tab) {
> +    if ($current_tab && ($tabs->{$tab}->{'path'} eq $current_tab)) {
>        $tabs->{$tab}->{"subtabs"} = $subtabs;
>        $tabs->{$tab}->{"current_subtab"} = $current_subtab;
>      }
>    }

> _______________________________________________
> Rt-devel mailing list
> Rt-devel at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel


-- 


More information about the Rt-devel mailing list