[Rt-devel] Re: [Rt-commit] r5987 - in rt/branches/3.6-RELEASE: . html/Tools/Elements

[Ruslan Zakirov]

This patch doesn't follow code style we use in RT.
1) one %INIT block at the bottom
2) ARGS block should be there also
3) comments in the bottom of the Tabs file must be dropped

On 9/19/06, jesse at bestpractical.com <jesse at bestpractical.com> wrote:
> Author: jesse
> Date: Tue Sep 19 03:40:52 2006
> New Revision: 5987
>
> Modified:
>    rt/branches/3.6-RELEASE/   (props changed)
>    rt/branches/3.6-RELEASE/html/Tools/Elements/Tabs
>    rt/branches/3.6-RELEASE/html/Tools/MyDay.html
>
> Log:
>  r27648 at pinglin:  jesse | 2006-09-19 09:40:40 +0200
>  RT-Ticket: 7876
>  RT-Status: resolved
>  RT-Update: correspond
>
>  Thanks! Applied:
>
>  From Brian Gallew <geek at burri.to>:
>   As shipped, RT-3.6.1 doesn't have a useful Tools/MyDays.html. I've
>   fixed it up so that it works seemingly correctly. Here is the patch that
>   takes care of it.
>
>
> Modified: rt/branches/3.6-RELEASE/html/Tools/Elements/Tabs
> ==============================================================================
> --- rt/branches/3.6-RELEASE/html/Tools/Elements/Tabs    (original)
> +++ rt/branches/3.6-RELEASE/html/Tools/Elements/Tabs    Tue Sep 19 03:40:52 2006
> @@ -59,6 +59,10 @@
>          title => loc('Reports'),
>          path  => 'Tools/Reports/index.html',
>      },
> +    c => {
> +        title => loc('My Day'),
> +        path  => 'Tools/MyDay.html',
> +    },
>  };
>
>  $m->comp('/Elements/Callback', tabs => $tabs, %ARGS);
> @@ -76,3 +80,7 @@
>  $current_subtab => undef
>  $Title => undef
>  </%ARGS>
> +
> +%# Local Variables:
> +%# mode:perl
> +%# End:
>
> Modified: rt/branches/3.6-RELEASE/html/Tools/MyDay.html
> ==============================================================================
> --- rt/branches/3.6-RELEASE/html/Tools/MyDay.html       (original)
> +++ rt/branches/3.6-RELEASE/html/Tools/MyDay.html       Tue Sep 19 03:40:52 2006
> @@ -43,7 +43,15 @@
>  %# those contributions and any derivatives thereof.
>  %#
>  %# END BPS TAGGED BLOCK }}}
> -<& /Elements/Header, title => "What I did today" &>
> +<%args>
> +$thispage => "MyDay.html"
> +</%args>
> +<%init>
> +my $title = loc("What I did today");
> +</%init>
> +
> +<& /Elements/Header, Title => $title &>
> +<& /Tools/Elements/Tabs, current_tab => "Tools/$thispage", Title => $title &>
>  (displaying new and open tickets for <%$session{'CurrentUser'}->Name%>)
>  <form method="post" action="MyDay.html">
>  <table width="100%" cellpadding="0" cellspacing="0">
> _______________________________________________
> Rt-commit mailing list
> Rt-commit at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
>


-- 
Best regards, Ruslan.