[Rt-devel] patch: Optimize recipients for Notifications Mails

[Dirk Pape]

Hello,

Thanks, but I see that it does not help with the issue I had (more than one 
notification scrip is fireing for the same person being AdminCc, Owner and 
OtherRecipient).

The optimization I did with this patch is already done by the MTA, which 
apparently does not send a message twice to one person within the same 
session.

Nevertheless the patch (or a slightly better version of it, that also 
removes duplicates in one Header field - I will send later) is useful, 
because cleaning the recipient header will help in a better "preview" on 
the Ticket/Update.html who will receive a message, and in the "recorded 
email" transactions.

For my original intention I have to cleanup my scrip logic.

Thanks, Dirk.


--Am 15. Juni 2007 16:52:26 +0400 schrieb Ruslan Zakirov 
<ruz at bestpractical.com>:

> ok.
>
> On 6/15/07, Jesse Vincent <jesse at bestpractical.com> wrote:
>>
>> On Jun 15, 2007, at 4:20 AM, Ruslan Zakirov wrote:
>>
>> > good patch, vote for applying
>>
>> Ok. Let's aim for 3.6.5?
>>
>>
>>
>> >
>> > On 6/15/07, Dirk Pape <pape-rt at inf.fu-berlin.de> wrote:
>> >> Hello,
>> >>
>> >> we found, that if we have ScripActions that notify more than one
>> >> watcher
>> >> group (e.g. "Notify AdminCC and Cc as Comment"), people get more
>> >> than one
>> >> message for the same notification, if they have more than one role
>> >> for the
>> >> ticket (e.g. beeing AdminCc and Cc).
>> >>
>> >> This is not necessary at all but only annoying, so I propose
>> >> following
>> >> general patch for Action/SendEmail.pm which removes unnecessary
>> >> recipient
>> >> entries: It removes every Cc already in To and every Bcc if
>> >> already in To
>> >> or Cc.
>> >>
>> >> The patch is tested here and behaves like expected. Will this make
>> >> it into
>> >> the core?
>> >>
>> >> <http://page.mi.fu-berlin.de/~pape/rt3/patches/rt/
>> >> optimize_recipients.patch>
>> >>
>> >> Regards, Dirk.
>> >> --
>> >> Dr. Dirk Pape (eAS - Projektleitung Campus Management)
>> >> Freie Universitaet Berlin
>> >> Grunewaldstr. 34a, 12165 Berlin
>> >> Tel. +49 (0)30 838 75143, Fax. +49 (0)30 838 54654
>> >> _______________________________________________
>> >> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/
>> >> rt-devel
>> >>
>> >
>> >
>> > --
>> > Best regards, Ruslan.
>> > _______________________________________________
>> > List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/
>> > rt-devel
>> >
>>
>>



-- 
Dr. Dirk Pape (eAS - Projektleitung Campus Management)
Freie Universitaet Berlin
Grunewaldstr. 34a, 12165 Berlin
Tel. +49 (30) 838 75143, Fax. +49 (30) 838 54654