[Rt-devel] RTx::EmailCompletion with LDAP : testers needed

[Roedel, Mark]

One correction:

In lib/RTx/EmailCompletion/Ldap.pm, line 20 currently reads

        $ldap->bind($RT::EmailCompletionLdapUser,
$RT::EmailCompletionLdapPass)

And should be

        $ldap->bind($RT::EmailCompletionLdapUser,
password=>$RT::EmailCompletionLdapPass)

I'm also not seeing the grey backgrounds, but haven't had time to look
at whether that's a problem with the plugin, or somehow something in our
local setup.  I'll hopefully have time to work with it some more
tomorrow.

--
Mark Roedel
Senior Programmer / Analyst
LeTourneau University



-----Original Message-----
From: nchuche at gmail.com [mailto:nchuche at gmail.com] On Behalf Of Nicolas
Chuche
Sent: Monday, November 12, 2007 3:39 PM
To: Roedel, Mark
Cc: rt-devel at lists.bestpractical.com
Subject: Re: [Rt-devel] RTx::EmailCompletion with LDAP : testers needed

Hello,

New rc available
http://gaspard.mine.nu/RTx-EmailCompletion-0.03rc2.tar.gz

> * Added EmailCompletionLdapUser and EmailCompletionLdapPass
> configuration variables to support LDAP servers that don't allow
> anonymous binding
>
> * Sorted the results of the LDAP search

Ok got it. I've change it a bit and applied it.

> One possible weakness I can see with my changes is that I don't think
> they'll allow for a case where the ldap server used for email
> autocompletion allows anonymous binds but the server used for
> authentication doesn't.  I'm not sure what the most graceful way would
> be to handle that scenario while still supporting fallthrough to an
> underlying LDAP configuration.

The best idea I can think of (is it english ?) is to verify that
LdapServer and EmailCompletionLdapServer are the same and if not,
don't fallback to LdapUser/LdapPass. I will do that way for the
moment. If you have a better idea, let me know.

I will keep the fallback for EmailCompletionBase and
EmailCompletionFilter because it seems good for those two.

> Also...I'm not sure how hard this would be, but for sites that use
both
> LDAP and RDBM lookups for email completion, I can see it being useful
> for the dropdown to indicate where each item originated.

Quite easy, LDAP emails now have light grey background. If you have a
better idea or a better color, let me know.

By the way, thanks for the patch and for your help.