[Rt-devel] [Rt-commit] r18632 - rt/3.8/trunk/lib/RT/Action

[Jesse Vincent]

I'm concerned that this change makes the regular expression too tight.
Previously, any value would work. 

I _know_ I've used values like "on", "true" and "y" in the patch.

how about instead matching on no|0|off?


On Tue, Mar 03, 2009 at 07:42:16AM -0500, elacour at bestpractical.com wrote:
> Author: elacour
> Date: Tue Mar  3 07:42:14 2009
> New Revision: 18632
> 
> Modified:
>    rt/3.8/trunk/lib/RT/Action/SendEmail.pm
> 
> Log:
> Take care of RT-Attach-Message value so we don't add attachments if the value
> is "no" for example (closes: #13259).
> Thanks to Paul Vlaar.
> 
> Modified: rt/3.8/trunk/lib/RT/Action/SendEmail.pm
> ==============================================================================
> --- rt/3.8/trunk/lib/RT/Action/SendEmail.pm	(original)
> +++ rt/3.8/trunk/lib/RT/Action/SendEmail.pm	Tue Mar  3 07:42:14 2009
> @@ -217,7 +217,8 @@
>          'mime_words_ok', );
>  
>      # Build up a MIME::Entity that looks like the original message.
> -    $self->AddAttachments if $MIMEObj->head->get('RT-Attach-Message');
> +    $self->AddAttachments if ( $MIMEObj->head->get('RT-Attach-Message')
> +                               && ( $MIMEObj->head->get('RT-Attach-Message') =~ /^yes$/i ) );
>  
>      $self->AddTickets;
>  
> _______________________________________________
> Rt-commit mailing list
> Rt-commit at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
> 

--