[rt-devel] ProcessTicketLinks

[Bradley Bell]

On Jun 7, 2013, at 9:30 AM, Kevin Falcone <falcone at bestpractical.com> wrote:

> On Fri, Jun 07, 2013 at 11:17:28AM +0000, Raed El-Hames wrote:
>> Thanks Kevin, that was the issue .. fixed now ..
>> By the way on a related note, have you folks put any thought into a
>> clean unmerge function ?? I know its been debated over the past few
>> years and wondering why you have n't done it .. is there a reason that
>> I should be aware off ?? my unmerge function:
>> Sets the effective id back to == id
>> Resets the status back to open
>> Removes any requestors from $self-> that exist in the unmerged ticket unless these existed in $self before the MergeInto transaction time ..
> 
> That's only some of the things done in a merge.  Check the _MergeInto
> method on RT::Ticket for more things that need to be unwound.
> 
> It's actually annoyingly difficult to untangle correctly, especially
> if you merge ticket 1 into 2 and then 2 into 3 and then want to
> unmerge ticket 1.
> 
> There is a branch in review for 4.2 to make it more obvious when
> you're about to merge the wrong tickets.
> 
> -kevin

I always thought it would be nice if  merging produced an SQL dump like shredding does. 

-Brad


> 
>> 
>> -----Original Message-----
>> From: rt-devel-bounces at lists.bestpractical.com [mailto:rt-devel-bounces at lists.bestpractical.com] On Behalf Of Kevin Falcone
>> Sent: 06 June 2013 18:49
>> To: rt-devel at lists.bestpractical.com
>> Subject: Re: [rt-devel] ProcessTicketLinks
>> 
>> On Wed, Jun 05, 2013 at 04:27:10PM +0000, Raed El-Hames wrote:
>>> Apologies for the long signature , its not in my control.
>>> I have created an unmerge function that worked well in 3.8 , however now I have moved to 4.0.10 it stopped working as expected.
>>> The problem I have is ProcessTicketLinks not being called from my
>>> local/lib/RT/Interface/Web_Local.pm and instead its being called from
>>> the main lib/RT/Interface/Web.pm
>>> 
>>> I have other functions in Web_Local.pm (example ShowRequestedPage) which are being called correctly .
>>> Have I missed anything special about ProcessTicketLinks ?? Any
>>> pointers will be greatly appreciated
>> 
>> You didn't include your code, so this is just a guess, but since ShowRequestedPage is in the RT::Interface::Web package while ProcessTicketLinks is in the HTML::Mason::Commands (to make it available easily to Mason components) I'm guessing that you don't have correct package lines.
> 
> 
> -- 
> RT Training in Seattle, June 19-20: http://bestpractical.com/training