[rt-users] Re: Feature Request: clicking reply on a comment should default to comment, not correspondence

Ian Grant Ian.Grant at cl.cam.ac.uk
Wed Jan 21 07:22:57 EST 2004


On Wed, 21 Jan 2004 11:46:35 +0000
Ian Grant <Ian.Grant at cl.cam.ac.uk> wrote:

> Thsi is always catching us out. About once a day one of us sends
> inappropriate comments to a requestor by clicking [reply] instead of
> [comment].
> 
> People are caught out when 'reply' replies to addresses that the
> original wasn't sent to.
> 
> Does anyone have a patch to fix this?

Minimalist hack: takes out the [reply] option for comments. You can
always use the [Comment] option and change the type to 'Respond'.

--- share/html/Ticket/Elements/ShowTransaction  2004-01-02
21:23:39.000000000 +0000
+++ local/html/Ticket/Elements/ShowTransaction  2004-01-21
12:19:31.000000000 +0000
@@ -165,7 +165,8 @@
 
 # If the transaction has anything attached to it at all
 if ($Transaction->Attachments->First && $ShowTitleBarCommands) {
-       if
($Transaction->TicketObj->CurrentUserHasRight('ReplyToTicket')) {
+       if
($Transaction->TicketObj->CurrentUserHasRight('ReplyToTicket') &&
+            ! ($Transaction->Type =~ /^Comment$/)) {
                $titlebar_commands .= 
                  "[<a href=\"Update.html?id=".
                  $Transaction->Ticket .
"&QuoteTransaction=".$Transaction->Id.



More information about the rt-users mailing list