[rt-users] The ShowSavedSearches right and a patch for SavedSearches.pm

[William J. Horka]

Hello all,

Does anyone have experience with granting the ShowSavedSearches right? I 
found that it wasn't working as I expected and posted this question and 
patch to the rt-devel list back in February and got no response. I 
noticed that the behavior is still the same in RT 3.6.7, so I was hoping 
that someone else in the user community might be able to tell me if I'm 
misinterpreting the documentation or if the patched behavior is preferable.

Thanks in advance.

      -Bill

-------- Original Message --------
Subject: SavedSearches.pm and the ShowSavedSearches right
Date: Tue, 26 Feb 2008 18:40:56 -0500
From: William J. Horka <whorka at hmdc.harvard.edu>
To: rt-devel at lists.bestpractical.com

Hello all,

I may be misinterpreting the documentation, but it appears to be that RT
is not behaving as documented with respect to the ShowSavedSearches
group right.

According to the RT wiki, "A user who has the ShowSavedSearches right to
a group is able to see/load the saved searches of that group. The user
must also have the global LoadSavedSearch right."

However, in practice, it seems that the function
RT::SavedSearches::_PrivacyObjects which "returns a list of objects that
can be used to load saved searches from" does not select the group
objects based on the user having the ShowSavedSearches group right, but
rather selects them based on whether the user is a member of the group.

I've verified that the relevant code in
RT::SavedSearches::_PrivacyObjects is identical in the subversion
3.6-RELEASE and 3.7-EXPERIMENTAL branches, so this doesn't appear to
have been yet identified as a bug.

The attached patch reflects the behavior I would expect to see based on
the documentation. Does this look correct?

       -Bill

-- 
William Horka
UNIX Systems Administrator
Harvard-MIT Data Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SavedSearches.pm.ShowSavedSearches.patch
Type: text/x-patch
Size: 896 bytes
Desc: not available
URL: <http://lists.bestpractical.com/pipermail/rt-users/attachments/20080617/f26dc082/attachment.bin>