[Rtir] RTIR 1.0.6rc1 - bug in .../RTIR/index.html

[Ruediger Riediger]

Hello Jesse,

[Bcc:'ed to <rtir-bugs at fsck.com>]

the link "x of 10 new unlinked Incident Reports..." does not work on 
RTIR home page. Here is the fix:

*** /opt/rt3/share/html/RTIR/Elements/NewReports.ORIG
--- /opt/rt3/share/html/RTIR/Elements/NewReports
***************
*** 61,67 ****
   <& ShowDate, date => $Ticket->DueObj &>
   </TD>
   <TD ALIGN=RIGHT>
! % if ($Ticket->Owner == $session{CurrentUser}->id) {
   [<A HREF="<% $RT::WebPath 
%>/RTIR/Incident/LinkToIncident.html?ClearRestrictions=1&id=<%$Ticket->Id%>"><&|/l&>Link</&></A>]
   [<A HREF="<% $RT::WebPath 
%>/RTIR/Update.html?id=<%$Ticket->Id%>"><&|/l&>Update</&></A>]
   % } elsif ($Ticket->Owner == $RT::Nobody->Id) {
--- 61,67 ----
   <& ShowDate, date => $Ticket->DueObj &>
   </TD>
   <TD ALIGN=RIGHT>
! % if ($Ticket->CurrentUserHasRight('ModifyTicket')) {
   [<A HREF="<% $RT::WebPath 
%>/RTIR/Incident/LinkToIncident.html?ClearRestrictions=1&id=<%$Ticket->Id%>"><&|/l&>Link</&></A>]
   [<A HREF="<% $RT::WebPath 
%>/RTIR/Update.html?id=<%$Ticket->Id%>"><&|/l&>Update</&></A>]
   % } elsif ($Ticket->Owner == $RT::Nobody->Id) {
***************
*** 95,100 ****
--- 95,101 ----
       my $cf = RT::CustomField->new($session{'CurrentUser'});
       $cf->LoadByNameAndQueue(Queue => $QueueObj->Id, Name => 
'_RTIR_State');
       $MyTickets->LimitCustomField(CUSTOMFIELD => $cf->Id, VALUE => 'new');
+     $fid = $cf->Id;
   }

   $MyTickets->RowsPerPage($rows);


Or the short version:
64c64
< % if ($Ticket->Owner == $session{CurrentUser}->id) {
---
 > % if ($Ticket->CurrentUserHasRight('ModifyTicket')) {
97a98
 >     $fid = $cf->Id;


...plus another minor bug fix (RTIR assumes only the owner can modify 
the tickets - this might not be true).

Any plans for an official RTIR 1.0.6 release?

Best regards,

	Ruediger Riediger

-- 
Dr. Ruediger Riediger                              Sun Microsystems GmbH
NSG - SunCERT                                             Komturstr. 18a
mailto:Ruediger.Riediger at Sun.com                          D-12099 Berlin
------------------------------------------------------------------------
NOTICE:  This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged information.
Any unauthorized review, use, disclosure or distribution is prohibited.
If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
------------------------------------------------------------------------
PGP 2048RSA/0x2C5020E9          964C E189 0FF0 8882  2BAB 65E2 6912 1FF2
------------------------------------------------------------------------