[Rtir] RTIR 1.0.6rc1 - bug with "Requestor email address" search criterion

[Ruediger Riediger]

Hello Jesse,

[Bcc:'ed to <rtir-bugs at fsck.com>]

your most annoying bug hunter again :-)

The "Requestor email address" search criterion is broken as the 
"LimitRequestor" was recoded to "LimitWatcher" but the change never made 
in the HTML page (two files need to change, see below):


*** /opt/rt3/share/html/RTIR/Elements/PickRestriction.ORIG
--- /opt/rt3/share/html/RTIR/Elements/PickRestriction
***************
*** 30,36 ****
   <INPUT TYPE=HIDDEN NAME="CompileRestriction" VALUE=1>

   <ul>
! <li><&|/l&>Owner is</&>  <& /Elements/SelectBoolean, Name => "OwnerOp",
                                           TrueVal=> '=',
                                           FalseVal => '!='
   &>
--- 30,40 ----
   <INPUT TYPE=HIDDEN NAME="CompileRestriction" VALUE=1>

   <ul>
! <li><&|/l&>Id</&> <& /Elements/SelectEqualityOperator, Name => "IdOp" &>
!
! <INPUT Name="ValueOfId" SIZE=7>
!
! <li><&|/l&>Owner</&>  <& /Elements/SelectBoolean, Name => "OwnerOp",
                                           TrueVal=> '=',
                                           FalseVal => '!='
   &>
***************
*** 37,45 ****
   <& /Elements/SelectOwner, Name => "ValueOfOwner" &>

   <li>
! <&|/l&>Requestor email address</&>
! <& /Elements/SelectMatch, Name => "RequestorOp" &>
! <INPUT Name="ValueOfRequestor" SIZE=20>

   <li>
   <&|/l&>Subject</&> <& /Elements/SelectMatch, Name => "SubjectOp" &>
--- 41,50 ----
   <& /Elements/SelectOwner, Name => "ValueOfOwner" &>

   <li>
! <&|/l&>Email address of</&>
! <& /Elements/SelectWatcherType, Name => "WatcherRole" &>
! <& /Elements/SelectMatch, Name => "WatcherRoleOp" &>
! <INPUT Name="ValueOfWatcherRole" SIZE=20>

   <li>
   <&|/l&>Subject</&> <& /Elements/SelectMatch, Name => "SubjectOp" &>




...plus I added a search criterion for the ticket Id. Comes handy when 
you want to merge e.g. with a known ticket number.


*** /opt/rt3/lib/RT/Interface/Web.pm.ORIG
--- /opt/rt3/lib/RT/Interface/Web.pm
***************
*** 646,651 ****
--- 646,662 ----
       }

       # }}}
+     ### \/ SunCERT: LimitId added \/ ###
+     # {{{ Limit id
+     if ( $args{ARGS}->{'ValueOfId'} ne '' ) {
+         $session{'tickets'}->LimitId(
+             VALUE    => $args{ARGS}->{'ValueOfId'},
+             OPERATOR => $args{ARGS}->{'IdOp'}
+         );
+     }
+
+     # }}}
+     ### /\ SunCERT: LimitId added /\ ###
       # {{{ Limit priority
       if ( $args{ARGS}->{'ValueOfPriority'} ne '' ) {
           $session{'tickets'}->LimitPriority(



Best regards,

	Ruediger Riediger

-- 
Dr. Ruediger Riediger                              Sun Microsystems GmbH
NSG - SunCERT                                             Komturstr. 18a
mailto:Ruediger.Riediger at Sun.com                          D-12099 Berlin
------------------------------------------------------------------------
NOTICE:  This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged information.
Any unauthorized review, use, disclosure or distribution is prohibited.
If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
------------------------------------------------------------------------
PGP 2048RSA/0x2C5020E9          964C E189 0FF0 8882  2BAB 65E2 6912 1FF2
------------------------------------------------------------------------