[Rtir] Modify RTIR_FindIP.pm script to filter IPs

Ruslan Zakirov ruz at bestpractical.com
Mon Jun 25 16:01:27 EDT 2012

On Wed, Jun 20, 2012 at 1:55 AM, David Moreau Simard <dmsimard at iweb.com> wrote:
> etc/RT_SiteConfig.pm:
> Set(@RTIR_IPv4_range_preference, qw (
>        )
> );

Feature is good to have, but to make it into RTIR core it should be
IPv6 aware. I don't see
much need in additional module, but it's ok. Code needs cleanup. It's
complex already and you
change makes it even more nested. Why don't you put the check into
AddIP method? I think
it belongs there.

Best regards, Ruslan.

More information about the Rtir mailing list