[SearchBuilder-devel] Re: [PATCH] filters

Ruslan Zakirov ruslan.zakirov at gmail.com
Thu Sep 22 21:02:22 EDT 2005

Comments from Jesse:

> I see why you moved the filters thing, but it feels a little more wrong to me on records than on columns.

> and Jifty::DBI::Filterable isn't quite right name
it's only abstract interface class and it was implemented only to
reach next goals:
1) one interface for all classes where you can define filters
2) and cover logic: unless you define own list of the output filters
we take reversed list of input filters
I don't know how to name it correctly and also don't like that I've
created new file for this.
Suggest another name for package.
Also we could move this code into Filter.pm file, but with different
package name.

> also, why the ->{decoded} hash to go along with the fetched hash?
It's required to optimize code a little, and would help us implement
any logic we want for load_* methods.

> also, "wants more docs" ;)

> otherwise, nice

On 9/22/05, Ruslan Zakirov <ruslan.zakirov at gmail.com> wrote:
> attachment :)
> On 9/22/05, Ruslan Zakirov <ruslan.zakirov at gmail.com> wrote:
> > Hello.
> >
> > Here is new filters implementation.
> > It's draft patch. I stuck with t/06filter_truncate.t on Pg.
> >
> > You can see concept.
> > Wait for your comments.
> >
> > --
> > Best regards, Ruslan.
> >
> --
> Best regards, Ruslan.

Best regards, Ruslan.

More information about the SearchBuilder-devel mailing list