[svk-devel] Win32 test path separator patch against trunk

[Kevin Light]

----- David Glasser <glasser at mit.edu> wrote:
> On 7/25/06, Kevin Light <klight at walkertechnical.com> wrote:
> > --- 03import-mime.t     (revision 1915)
> >
> > +++ 03import-mime.t     (patch win32-test-path level 1)
> >
> > @@ -22,16 +22,16 @@
> >
> 
> Random technical point: do your patch files on disk really have these
> extra newlines after the --- +++ and @@ lines, or is this mangling
> from the mail system or something? gnu patch didn't like your patch
> because of that. (And svk patch didn't want to apply it since it was
> against your local branch which my svk knows nothing of -- perhaps
> this is a shortcoming of svk patch that should be addressed.)

The patch file does indeed have the extra blank lines.  Previous patches also have them so its nothing new.  My guess is that its a win32 eol thing when the patch is created.

Sorry for the informal patch.  rbellamy was asking about my hacks to resolve some of the test failures on win32 so I quickly created the patch.  My guess, again, was that it should have been against my local copy in my repository and not from my wc.  I suppose that wc patches should be able to be applied by others or the correct way should "recommended" when the user attempts what I did.

> Anyway, patch has been applied.  Can you let me know if trunk passes
> tests on win32 now?

Thanks!  I'll test it out shortly.

Kevin