[svk-devel] Problem in SVN::Mirror::Ra.pm

[Michael Scherer]

Le samedi 28 octobre 2006 à 01:51 -0400, Chia-Liang Kao a écrit :
> Thanks so much for looking into this.  I noticed the problem a while
> ago with newer client library, and I think this is like what you said,
> client/server version combination problems.  Also the behaviour is
> different depending on which ra transport is being used :(
> 
> One of the reasons that get_latest_revnum is messy is that it's so
> hard to setup automated tests for different versions of client and
> server to test with.  I might try to do something on this next week,
> or at least apply your patch..

any progress on this bug ?

i have seen it too, using latest svk and svn, and I finally nailed it
down to svn::mirror :

/tmp $ svm init mirror/test2 http://svn.collab.net/repos/svn/trunk
/tmp $ LC_ALL=C svm sync mirror/test2  HEAD                       
RA layer request failed: REPORT request failed on '/repos/svn/!
svn/bc/23285/trunk': REPORT of '/repos/svn/!svn/bc/23285/trunk': 200 OK
(http://svn.collab.net)
at /usr/lib/perl5/vendor_perl/5.8.8/SVN/Mirror/Ra.pm line 626

$ rpm -q perl-SVN perl-SVN-Mirror
perl-SVN-1.4.3-1mdv2007.1
perl-SVN-Mirror-0.72-1mdv2007.1


If I modify RA.pm like this, it work, but it is just a very very quick
hack to let me use svk.


 $ diff -u /usr/lib/perl5/vendor_perl/5.8.8/SVN/Mirror/Ra.pm /tmp/Ra.pm 
--- /usr/lib/perl5/vendor_perl/5.8.8/SVN/Mirror/Ra.pm   2007-01-30
01:30:19.000000000 +0100
+++ /tmp/Ra.pm  2007-01-30 01:30:09.000000000 +0100
@@ -621,7 +621,7 @@
        # vs svnserve 1.1, it retrieves all logs and leave the
connection
        # in an inconsistent state.
        if ($SVN::Core::VERSION ge '1.2.0' && $self->{rsource} !~
m/^svn/) {
-           my $_start = $self->{rsource} =~ m/^file/ ? 0 : 1;
+           my $_start = $self->{rsource} =~ m/^file/ ? 0 : -1;
            $ra->get_log ([''], -1, $_start, 1, 0, 1,
                           sub { $rev = $_[1] });
        }

-- 
Michael Scherer