[svk-devel] Review log message when push'ing to mirror

[John Peacock]

Ruslan Zakirov wrote:
> As far as I understand 'svk sm -l //src //dst' is exactly what you
> want. It merges everything at once and opens an editor for you to edit
> merged log message. For those who don't want to edit log there is
> option -m in smerge command that allow them to replace log with a
> message or add heading to merged log. So we have four variants at
> least:
> 'svk sm -l //src //dst' - merged log, opens editor
> 'svk sm -m 'xxx' //src //dst' - replace log with a message, no editor
> 'svk sm -l -m 'xxx' //src //dst' - add a message before log, no editor
> 'svk sm -l -m '' //src //dst' - just merge logs without an editor
> And the last variant is what's 'svk push --lump' does.

Ah, so it does!  That isn't well documented, then.  So I can revise my 
patch to the much simpler:

=== lib/SVK/Command/Push.pm
==================================================================
--- lib/SVK/Command/Push.pm     (revision 2544)
+++ lib/SVK/Command/Push.pm     (local)
@@ -63,6 +63,7 @@
       'S|sign'          => 'sign',
       'P|patch=s'        => 'patch',
       'verbatim'                => 'verbatim',
+     'review-message'   => 'review_message'
      );
  }

@@ -83,6 +84,11 @@
          $self->{message} = '';
          delete $self->{incremental};
      }
+    elsif ( $self->{review_message} ) {
+       $self->{lump} = 1;
+       $self->{log}++;
+       delete $self->{incremental};
+    }
      else {
          $self->{incremental}++;
      }

Since it still much nicer for the user not to have to remember the two 
URL's involved...

John