[svk-devel] Review log message when push'ing to mirror

John Peacock john.peacock at havurah-software.org
Wed Oct 17 10:44:53 EDT 2007


Ruslan Zakirov wrote:
>> @@ -83,6 +84,11 @@
>>           $self->{message} = '';
> It even can be much simpler, just add "unless $self->{review_message}
> " to the above statement.
> 
>>           delete $self->{incremental};
>>       }
>> +    elsif ( $self->{review_message} ) {
>> +       $self->{lump} = 1;

Except that it doesn't make much sense to have --review-message if lump 
isn't active, and I don't think we would want to require --lump on the 
commandline independent of this flag.

John


More information about the svk-devel mailing list