[svk-devel] Review log message when push'ing to mirror

[Ruslan Zakirov]

I really think that it should work in the following way:
svk push --lump
svk push --lump --review-message
svk push --patch --review-message
svk push --review-message - makes not much sense and should issue
warning or even die with error message.
Yes, it's more typing, but flexible. Works as modifier instead of new
sub-command.


On 10/17/07, John Peacock <john.peacock at havurah-software.org> wrote:
> Ruslan Zakirov wrote:
> >> @@ -83,6 +84,11 @@
> >>           $self->{message} = '';
> > It even can be much simpler, just add "unless $self->{review_message}
> > " to the above statement.
> >
> >>           delete $self->{incremental};
> >>       }
> >> +    elsif ( $self->{review_message} ) {
> >> +       $self->{lump} = 1;
>
> Except that it doesn't make much sense to have --review-message if lump
> isn't active, and I don't think we would want to require --lump on the
> commandline independent of this flag.
>
> John
> _______________________________________________
> svk-devel mailing list
> svk-devel at bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-devel
>


-- 
Best regards, Ruslan.