[rt-devel] bug? Moving tickets into queue user cannot view

[Matthew Watson]

You will probably have to patch ModifyAll.pm with something similar too.


-----Original Message-----
From: rt-devel-admin at lists.fsck.com
[mailto:rt-devel-admin at lists.fsck.com]On Behalf Of Matthew Watson
Sent: Wednesday, 9 January 2002 5:29 PM
To: rt-devel at lists.fsck.com
Subject: RE: [rt-devel] bug? Moving tickets into queue user cannot view



Ok, I've fixed this up, here are the diff files (against 2.0.8) , never
really used diff, so your milage may differ. :)


----------------------------------------------------------------------------
-------
rtbase/lib/RT/Ticket.pm

1304c1304
<     unless ($self->OwnerObj->HasQueueRight(Right=> 'CreateTicket',
---
>     unless ($self->OwnerObj->HasQueueRight(Right=> 'OwnTicket',
2404c2404,2405
<     return($self->SetOwner($RT::Nobody->UserObj, 'Untake'));
---
>     #$RT::Logger->debug("mwatson: $RT::Nobody->Id\n");
>     return($self->SetOwner($RT::Nobody->Id, 'Untake'));


copy rtbase/WebRT/html/Ticket/Modify.html to
/rtbase/local/WebRT/html/Ticket/Modify.html

Then run this diff.
25a26,32
> # Need to reload incase user can no longer view it, eg queue has changed.
>
> $TicketObj = LoadTicket($id);
> unless ($TicketObj->CurrentUserHasRight('ShowTicket')) {
>         Abort("No permission to view ticket");
> }
>
----------------------------------------------------------------------------
-------

Regards
Mat watson.


-----Original Message-----
From: rt-devel-admin at lists.fsck.com
[mailto:rt-devel-admin at lists.fsck.com]On Behalf Of Matthew Watson
Sent: Tuesday, 8 January 2002 6:24 PM
To: rt-devel at lists.fsck.com
Subject: [rt-devel] bug? Moving tickets into queue user cannot view


Heya.

 I've found that if a user changed the queue on a ticket from a queue they
can view, to a queue they cannot view then the page just stalls, and the
apache process goes crazy and up all the memory it can.
I noticed this also happened in rt1, with the only difference being that it
was a perl process that went crazy, for obvious reasons.

 I suspect I should just be able to put something like

unless ($Ticket->CurrentUserHasRight('ShowTicket')) {
        Abort("No permission to view ticket");
    }

into Modify.html

 Should this work?
Anyone else noticed this?

Mat.


_______________________________________________
rt-devel mailing list
rt-devel at lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel


_______________________________________________
rt-devel mailing list
rt-devel at lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel