[rt-users] Hide ability to 'Comment' from unprivileged/SelfServiceusers

[Schultz, Eric]

I'm not sure about where to fix it for self-service, but these places
should give you a general hint for the changes I made:


--- ./Ticket/Update.html        2005/10/13 23:50:37     1.7
+++ ./Ticket/Update.html        2005/11/16 23:58:17     1.8
@@ -202,9 +202,7 @@
 $CanRespond = 1 if ( $TicketObj->CurrentUserHasRight('ReplyToTicket')
or
                      $TicketObj->CurrentUserHasRight('ModifyTicket') );

-$CanComment = 1 if ( $TicketObj->CurrentUserHasRight('CommentOnTicket')
or
-                     $TicketObj->CurrentUserHasRight('ModifyTicket') );
-
+$CanComment = 1 if ( $TicketObj->CurrentUserHasRight('CommentOnTicket')
);

 # {{{ deal with deleting uploaded attachments
 foreach my $key (keys %ARGS) {
===============================================================

--- ./Ticket/ModifyAll.html     2005/10/14 16:27:02     1.3
+++ ./Ticket/ModifyAll.html     2005/11/16 23:57:18     1.4
@@ -146,8 +146,7 @@
 $CanRespond = 1 if ( $Ticket->CurrentUserHasRight('ReplyToTicket') or
                      $Ticket->CurrentUserHasRight('ModifyTicket') );

-$CanComment = 1 if ( $Ticket->CurrentUserHasRight('CommentOnTicket') or
-                     $Ticket->CurrentUserHasRight('ModifyTicket') );
+$CanComment = 1 if ( $Ticket->CurrentUserHasRight('CommentOnTicket') );


 my (@wresults, @results,  @dresults, @lresults, @cf_results);
================================================================

--- ./share/html/Ticket/Elements/Tabs   2005/07/11 23:41:26     1.3
+++ ./share/html/Ticket/Elements/Tabs   2005/11/17 00:00:28     1.4
@@ -172,8 +172,7 @@
     }
 }

-if (    $Ticket->CurrentUserHasRight('ModifyTicket')
-     or $Ticket->CurrentUserHasRight('CommentOnTicket') ) {
+if ( $Ticket->CurrentUserHasRight('CommentOnTicket') ) {
     $actions->{'F'} = { title => loc('Comment'),
                         path  =>
"Ticket/Update.html?Action=Comment&id=" . $id,
     };

 

> -----Original Message-----
> From: Matt Nichols [mailto:mnichols at wayport.net] 
> Sent: Tuesday, January 24, 2006 11:14 AM
> To: Schultz, Eric; rt-users
> Subject: RE: [rt-users] Hide ability to 'Comment' from 
> unprivileged/SelfServiceusers
> 
> Eric,
> 
> Do you recall what you had to modify to make this change?
> 
> -Matt
> 
> -----Original Message-----
> From: Schultz, Eric [mailto:ESchultz at corp.untd.com] 
> Sent: Monday, January 23, 2006 11:11 AM
> To: Matt Nichols; rt-users
> Subject: RE: [rt-users] Hide ability to 'Comment' from
> unprivileged/SelfServiceusers
> 
> Unfortunately, I believe the right "ModifyTicket" implicity grants
> "CommentOnTicket".  I think I hacked our code so that this wasn't the
> case, and you had to explicitly grant CommentOnTicket if you wanted
> comments, even if you already had ModifyTicket.
> 
> ________________________________
> 
> 	From: rt-users-bounces at lists.bestpractical.com
> [mailto:rt-users-bounces at lists.bestpractical.com] On Behalf Of Matt
> Nichols
> 	Sent: Monday, January 23, 2006 9:05 AM
> 	To: rt-users
> 	Subject: [rt-users] Hide ability to 'Comment' from
> unprivileged/SelfServiceusers
> 	
> 	
> 
> 	Hello,
> 
> 	 
> 
> 	Currently all of our RT users are unprivileged members of the
> group 'employees' that have the following global group rights:
> 
> 	 
> 
> 	User Defined Groups
> 
> 	Employees:
> 
> 	 
> 
> 	CreateTicket
> 
> 	DeleteTicket
> 
> 	ModifyCustomField
> 
> 	ModifyTicket
> 
> 	OwnTicket
> 
> 	ReplyToTicket
> 
> 	SeeCustomField
> 
> 	 
> 
> 	Although the 'employees' group does not have the global right
> "CommentOnTicket" the users in this group (via SelfService) still have
> the ability to comment on tickets. What is the proper way to 
> disable the
> ability to 'comment' on a ticket? We'd like the users in this group to
> only have the ability to 'reply' to tickets. 
> 
> 	 
> 
> 	Thanks.
> 
> 	 
> 
> 	-Matt
> 
>